improvement(desktop): Electron E2E for desktop tool lifetimes against a live local Sim

[waleedlatif1]

Summary

• New Electron E2E spec runs the real desktop app against a live local Sim (Postgres, Redis, realtime). A recording proxy sits at the app origin and a scripted stand-in worker sits at SIM_AGENT_API_URL.
• Covers the ungated desktop fixes:
  • a browser call issued after switching chats fails as not started after the 15 s pickup grace (fix(mothership): fail unclaimed desktop calls fast and stop dropping them silently #8652)
  • leaving the chat doesn't end a running read_local_file, and an import survives chat switches (fix(mothership): keep local file tools running when the chat view changes #8666)
  • Stop from the reopened chat cancels the running import (fix(mothership): keep local file tools running when the chat view changes #8666)
  • signing out cancels a running desktop tool at sign-out (fix(mothership): end desktop tools at sign-out and settle held reports as final #8673)
  • unapproved reads and terminal runs, and a claim that arrives after Stop, are refused (fix(mothership): refuse desktop claims for unapproved or stopped calls #8643)
• Flag-off dormancy (feat(desktop): device registry, inbox and leased claims for a background executor #8644/feat(desktop): bind turns to a desktop and enforce its deadlines from the row #8650/fix(desktop): inbox persistence order, desktop-only overdue sweep, and ungated pickup windows #8685): a foreground round trip with a desktop tool works, the server doesn't bind a desktop that offers itself, no desktop_devices row is written, no executor routes are hit, and no inbox doorbell is published.
• Assertions are on observable outcomes: the result the model is resumed with, the workspace files, the persisted call rows, and the requests that reach Sim.
• The spec skips unless a live Sim is configured. A new desktop-live-e2e CI job starts one (dev app, realtime, Postgres, Redis), warms the routes the tests use, and runs the spec under Xvfb.

Type of Change

• Tests

Testing

• 8/8 green on staging 482f146d, on Linux/Xvfb and on macOS
• The CI step was run from scratch on a Linux runner
• Each test fails when its fix is reverted

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 7, 2026 4:32am UTC

[cubic-dev-ai]

All reported issues were addressed across 5 files

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Turn on auto-fix | Re-trigger cubic</sub>

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Adds end-to-end tests for desktop tools against a local app.

The PR appears safe to merge; no actionable issue remains.

What we checked:

• Original claim cannot be skipped: The proxy forwards the abandoned claim on release. The test checks that original request’s status before sending the replay.

Summary

Adds eight Electron E2E tests against a live local Sim, plus a dedicated CI job with PostgreSQL, Redis, and realtime.

• Covers chat switches, Stop, sign-out, approval checks, and behavior with the background executor off.
• The latest change delivers the held claim even after Electron disconnects and checks that claim’s own 410 response.
• Previous findings are addressed: shared helpers are used, Redis monitoring waits for acknowledgment, and the delayed claim cannot be skipped. The Electron installation finding was correctly disputed by waleedlatif1 and conceded.
• No new actionable issues found. The live suite was not run during this review.

Diagram

sequenceDiagram
  participant Electron
  participant Proxy as Recording proxy
  participant Sim as Local Sim
  participant Agent as Scripted agent
  Electron->>Proxy: Desktop claim
  Note over Proxy: Hold the original request
  Electron->>Proxy: Stop
  Proxy->>Sim: Stop
  Sim-->>Proxy: Call cancelled
  Note over Proxy: Release claim even if Electron disconnected
  Proxy->>Sim: Original desktop claim
  Sim-->>Proxy: 410
  Note over Proxy: Record original reply separately from replay

Loading

_{Reviews (5) · Last reviewed commit: "improvement(desktop): deliver the claim ..." · Reviewed by Greptile}

[waleedlatif1]

@greptileai review

[waleedlatif1]

@greptileai review

[waleedlatif1]

@greptileai review

[waleedlatif1]

@greptileai review