feat(projects): enforce Project membership and retire the connector by mzxchandra · Pull Request #8590 · simstudioai/sim

mzxchandra · 2026-10-02T22:32:41Z

Summary

Complete the migration to workspace.project_id after #8830 has deployed. Release 2 migrations run before application promotion, while release 1 still serves traffic. The registered runner therefore switches the sole membership authority before incremental backfill, keeping live writes and reconciliation consistent without dual writes or synchronization triggers.

SQL 0407 is a placeholder; the existing TypeScript migration runner owns 0031_project_membership. Expansion is 0406, following upstream 0405 OAuth. The final schema stores one Project foreign key on each workspace, enforces NOT NULL and ON DELETE RESTRICT, and removes project_workspace.
Under the operator session mutex, cutover runs in a short bounded transaction with workspace ACCESS EXCLUSIVE NOWAIT. Connector mode requires an intact connector and all columns NULL. The transaction updates only the checked singleton to column mode and commits before discovery or bulk backfill. Transient contention retries the whole transaction; an already committed switch is idempotent and never reversed on later failure.
Compatible feat(projects): move Project membership to the workspace column #8830 transactions hold the shared workspace barrier before selecting authority, including before repeatable-read snapshots. After cutover, they write the column and read legacy assignments only where the column is NULL. Final application code uses the column directly.
Reconcile in bounded transactions: at most 50 singletons or one complete fork family per assignment transaction. Preserve legitimate Project identity; validate grouping, ownership, scope, lineage and lifecycle before final enforcement. Never unarchive workspaces or workflows. Ambiguous membership or ownership and unfinished provider cleanup stop for reviewed remediation; committed progress and cleanup journal state survive retries.
Manual assignment/repair requires column mode and current drain acknowledgment; read-only planning remains available beforehand. Fresh final schema push initializes column authority only for the explicitly verified empty final-schema bootstrap and preserves the marker on replay. Expansion databases cannot bypass the registered migration through schema push.

Deployment prerequisites and rollback

Deploy #8830 first. With ALL_AT_ONCE routing, old servers receive no fresh requests after traffic cutover. Before this migration switches authority, verify the exact compatible digest and completion of concrete membership-sensitive old in-flight operations and worker activity. Mere container retention or long workflow execution does not establish a membership dependency. The database barrier drains participating transactions; operational drain evidence and the deployment preflight remain required.

If reconciliation stops after switching, keep column mode, resolve the reported conflicts through the reviewed operator path, and resume the normal migration runner. Operator invocation outside the deployment workflow still requires fresh release/drain evidence and a direct primary connection; never insert a completion receipt manually.

The authority-aware #8830 release is the oldest supported application rollback after the switch and after contraction. Keep the expanded/contracted schema and project_membership_rollout column-phase row. Never demote authority or deploy pre-#8830 code. No third compatibility release or marker-cleanup release is required.

Type of Change

Feature / database migration

Testing

Synchronized the expansion lint fix through a merge. The final-release tree is unchanged: connector-phase application tests remain intentionally absent after retirement.
Current head: e5da5c8abdb6c649fe73d855c95c24277a88614f, integrating expansion b9bc57287107d1ebe7618f5031725a0131c7c291 and staging OAuth0405; Project expansion0406 and enforcement0407.
Thirteen focused cutover/enforcement checks pass, covering the real marker migration, interrupted discovery and resume, live column writes after cutover, receipt retry, and shadow-schema isolation with caller search-path restoration. Nine real database/Redis repair cases and final-schema push/replay pass. Fresh migration through0407 and the affected OAuth fixture regression pass; targeted typechecks and schema drift checks pass.
Actual registered-runner HTTP proof: six connector-phase checks pass, then the runner assigns nine workspaces in five batches and completes0031. Three post-contraction checks pass on the same R1 process, preserving membership, ownership, archive states and workflow content and exercising create/fork/detach/archive/account deletion.
Direct-port old/new cases establish conditional compatibility only. They do not imply fresh requests reach old servers after production cutover. External provider/storage cleanup and live production drainage remain explicit prerequisites outside the synthetic proof.
Full hosted CI and fresh Greptile/cubic reviews are pending for this head. The standard repository integration matrix applies, with no additional Project-specific PostgreSQL16 CI or broad local CI repetition.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (exact-head hosted CI and reviews pending)
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-10-02T22:32:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 10, 2026 5:46am UTC

…ty-enforcement # Conflicts: # apps/sim/lib/projects/__integration__/foundation.integration.ts

…ty-enforcement

cubic-dev-ai

All reported issues were addressed across 162 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

Lock and verify effective legacy memberships before materializing reviewed assignments and applying the shared detach policy. Reject resume reports whose code hash differs before changing their checkpoint. Isolate local pubsub subscriber failures so healthy archive subscribers still receive notifications. Extend existing CLI and real-database integration coverage for mixed memberships, concurrent and stale connector changes, unchanged mismatched reports, replay, and local subscriber delivery.

mzxchandra · 2026-10-10T00:38:42Z

@greptile

mzxchandra · 2026-10-10T00:38:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T00:38:48Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 165 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

mzxchandra · 2026-10-10T01:31:18Z

@greptile

mzxchandra · 2026-10-10T01:31:20Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T01:31:26Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 166 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

mzxchandra · 2026-10-10T05:43:17Z

@greptile Please review the current head 406a78f, including authority cutover before reconciliation, shared enforcement search-path isolation, and final expansion integration.

mzxchandra · 2026-10-10T05:43:19Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T05:43:25Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

mzxchandra · 2026-10-10T05:46:24Z

@greptile Please review current head e5da5c8. This merge synchronizes the expansion lint fix; the enforcement source tree is unchanged from 406a78f.

mzxchandra · 2026-10-10T05:46:26Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T05:46:35Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

mzxchandra added 7 commits October 2, 2026 00:31

feat(projects): add project identity and lifecycle foundation

00a83d0

feat(projects): create projects with their initial environment

aa9b415

docs(projects): record project files follow-up

91cba23

docs(projects): explain project and workspace creation flows

0980ad1

fix(projects): stage activation after compatible writers deploy

a14b448

feat(projects): enforce membership after the staged backfill

5121347

fix(projects): retry writes after concurrent membership changes

523338a

mzxchandra mentioned this pull request Oct 2, 2026

feat(projects): add project identity and lifecycle foundation #8580

Merged

6 tasks done

vercel Bot deployed to Preview October 2, 2026 22:34 View deployment

fix(projects): align integration fixtures with membership constraints

dc5e301

vercel Bot deployed to Preview October 2, 2026 23:01 View deployment

mzxchandra added 5 commits October 2, 2026 16:34

refactor(projects): prepare compatible writers for the SQL backfill

c1c8e5d

Merge branch 'feat/project-entity-foundation' into codex/project-enti…

2e94a13

…ty-enforcement # Conflicts: # apps/sim/lib/projects/__integration__/foundation.integration.ts

refactor(projects): backfill through bounded SQL migration batches

5e11d7d

fix(projects): clean up automatically created fixture Projects

99189f2

Merge branch 'feat/project-entity-foundation' into codex/project-enti…

78f773d

…ty-enforcement

vercel Bot deployed to Preview October 2, 2026 23:54 View deployment

fix(projects): backfill only families missing membership

2ecbfdf

vercel Bot deployed to Preview October 3, 2026 00:00 View deployment

mzxchandra changed the title ~~feat(projects): enforce membership after the staged backfill~~ feat(projects): backfill and enforce membership in SQL Oct 3, 2026

mzxchandra added 2 commits October 2, 2026 17:19

chore(projects): merge staging into foundation

30bc9d8

chore(projects): merge updated foundation into enforcement

b5cc3c4

vercel Bot deployed to Preview October 3, 2026 00:24 View deployment

fix(projects): bound the trigger installation lock window

2afc652

vercel Bot deployed to Preview October 3, 2026 01:06 View deployment

mzxchandra added 4 commits October 2, 2026 18:21

fix(workflows): guard restore against concurrent workspace archive

6dfbc4f

fix(projects): keep workflow lifecycle guards at workspace scope

8965210

fix(workflows): guard restore against concurrent workspace archive

552ce68

Merge branch 'feat/project-entity-foundation' into codex/project-enti…

8be18e5

…ty-enforcement

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread apps/sim/lib/projects/backfill-repair.ts Outdated

Comment thread apps/sim/scripts/backfill-projects.ts Outdated

vercel Bot deployed to Preview October 10, 2026 00:01 View deployment

greptile-apps Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/lifecycle.ts

mzxchandra added 3 commits October 9, 2026 17:26

test(projects): align fixture lifecycle with enforced project ownership

639c8ca

fix(projects): integrate reviewed repair and fixture corrections

1e4499e

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread apps/sim/lib/projects/__integration__/backfill-repair.integration.ts Outdated

vercel Bot deployed to Preview October 10, 2026 00:44 View deployment

mzxchandra added 3 commits October 9, 2026 18:16

test(projects): skip archive repair suite when Redis is unset

c704293

merge: integrate renumbered Project expansion and staging fixtures

b2718cb

chore(projects): normalize enforcement SQL whitespace

d0a9792

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread packages/db/scripts/reconcile-project-membership.ts

vercel Bot deployed to Preview October 10, 2026 01:36 View deployment

mzxchandra added 3 commits October 9, 2026 22:26

feat(projects): commit membership authority before reconciliation

d8a9627

merge: integrate Project authority switch into enforcement

32f49e3

merge: sync Project enforcement with expansion 0406

406a78f

merge: synchronize expansion fixture lint fix

e5da5c8

vercel Bot temporarily deployed to Preview October 10, 2026 05:46 Inactive

Conversation

mzxchandra commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Deployment prerequisites and rollback

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mzxchandra commented Oct 2, 2026 •

edited

Loading

vercel Bot commented Oct 2, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading