fix(desktop): require folder permission for native file tools by waleedlatif1 · Pull Request #8345 · simstudioai/sim

waleedlatif1 · 2026-09-26T21:48:58Z

Summary

Ask before native reads or imports from an unapproved folder, remember approval across chats and restarts, and support revocation through File → Folder Access.
Add an off-by-default Full file access toggle in Desktop settings and remove the sleep setting helper text. Full file access bypasses folder prompts while retaining account, origin, cancellation, and filesystem identity checks; sign-out and server changes clear access.
Revalidate background calls before saving approval, share concurrent consent decisions without coupling cancellation, and show standalone consent without reopening a closed main window.
Verify native descriptors with lossless filesystem identities, reject replaced directories, and clear remembered grants even when persisting the Full file access reset fails.

Type of Change

Bug fix and feature

Testing

Full CI passed on the final rebased head: lint, all audits and workspace type checks, build, application and script suites, all integration shards, and HTTP E2E suites.
Real Electron E2E: 95 passed, 15 environment-specific skips; real Sim + Electron E2E: 12 passed; universal packaged-app smoke passed. CI retains reports, traces, and failure screenshots.
Native regression negative controls failed on pre-fix behavior for offline approval, closed-window reopening, grant cleanup after storage failure, hidden-browser throttling, and filesystem identity handling.
Repeated pinned-runtime consent checks passed without retries. An advisory canary round exposed one sign-out timing failure; the subsequent unchanged diagnostic repeat passed 10/10 without retries.
Manual packaged-app QA verified real sign-in, consent, cross-chat reuse, denial, revocation, restart persistence, native import with matching preview contents, and sign-out grant cleanup. Browser alert/confirm and unsaved-draft Stay, Escape, and Leave paths also passed.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-26T21:49:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 9, 2026 2:33am UTC

cubic-dev-ai

All reported issues were addressed across 8 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

greptile-apps · 2026-09-26T21:53:23Z

Confidence Score: 5/5

[High impact] The PR appears safe to merge based on the reviewed changes and resolved previous findings.

Summary

This PR adds folder consent and remembered grants for desktop native file tools, an opt-in Full file access setting, and descriptor-based checks for file access. It also adds cancellation, revocation, and Electron end-to-end coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Call[Authorized file-tool call] --> Access{Full access or folder grant?}
  Access -->|Yes| Verify[Revalidate call and folder identity]
  Access -->|No| Consent[Ask for folder consent]
  Consent --> Verify
  Verify --> Native[Open verified native descriptor]
  Native --> Result[Return bounded result]

_{Reviews (11) · Last reviewed commit: "fix(desktop): revalidate folder consent ..." · Reviewed by Greptile}

waleedlatif1 · 2026-09-26T22:08:01Z

@greptile

waleedlatif1 · 2026-09-26T22:08:03Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:08:08Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 13 files

_{Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic}

waleedlatif1 · 2026-09-26T22:31:52Z

@greptile

waleedlatif1 · 2026-09-26T22:31:54Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:31:59Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 15 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-26T22:52:04Z

@greptile

waleedlatif1 · 2026-09-26T22:52:05Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:52:10Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 20 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-26T22:59:20Z

@greptile

waleedlatif1 · 2026-09-26T22:59:21Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:59:27Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-10-09T00:21:39Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T00:21:44Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 29 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T02:19:33Z

@greptile

waleedlatif1 · 2026-10-09T02:19:47Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T02:19:53Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

1 issue found across 34 files

Confidence score: 3/5

In directory.cc, a stale or repeated closeFile call can close an unrelated resource if the descriptor has been reused. Track descriptors opened by openApproved and validate them before closing.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/desktop/native/directory.cc">

<violation number="1" location="apps/desktop/native/directory.cc:305">
P2: `closeFile` closes whatever integer it receives, so a stale or doubled close can hit a reused descriptor. Track descriptors opened by `openApproved` (for example, a set checked before close) or wrap them in a handle that can be closed only once.</violation>
</file>

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T02:26:16Z

@greptile Please review the current PR diff against staging. This branch was rebased onto 900afc3. Workflow tests and their run reporting came from staging PR #8773; they are not changed by this PR, as confirmed by the current Files changed list. Please reassess the confidence score for this PR’s 34 changed files at 4cf15ef, excluding changes already in its staging base.

waleedlatif1 · 2026-10-09T02:26:18Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T02:26:24Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 34 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T02:33:19Z

@greptile Please review the current 34-file PR diff against staging at 5282735. This is a clean rebase onto 1ed08d8 with no changes to desktop source or tests since the prior 5/5 review.

waleedlatif1 · 2026-10-09T02:33:20Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T02:33:27Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 34 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

vercel Bot temporarily deployed to Preview September 26, 2026 21:49 Inactive

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/src/main/local-file-permissions.ts Outdated

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/src/main/local-file-permissions.ts Outdated

Comment thread apps/desktop/src/main/local-file-permissions.ts Outdated

Comment thread apps/desktop/e2e/local-files.spec.ts Outdated

waleedlatif1 force-pushed the codex/desktop-local-file-consent branch from d43d45a to 6ca8a97 Compare September 26, 2026 22:07

vercel Bot temporarily deployed to Preview September 26, 2026 22:07 Inactive

waleedlatif1 changed the title ~~fix(desktop): ask before accessing local files~~ fix(desktop): require folder permission for native file tools Sep 26, 2026

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

waleedlatif1 force-pushed the codex/desktop-local-file-consent branch from 6ca8a97 to b5ae75a Compare September 26, 2026 22:31

vercel Bot temporarily deployed to Preview September 26, 2026 22:31 Inactive

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/src/main/local-files.ts Outdated

Comment thread apps/desktop/src/main/ipc.ts

waleedlatif1 requested a review from a team as a code owner September 26, 2026 22:51

vercel Bot deployed to Preview September 26, 2026 22:53 View deployment

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/native/directory.cc

Comment thread apps/desktop/src/main/local-files.ts

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/src/main/local-files.ts

vercel Bot temporarily deployed to Preview September 26, 2026 22:59 Inactive

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/desktop/src/main/desktop-settings.ts

Comment thread apps/desktop/src/main/index.ts Outdated

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/desktop/src/main/index.ts Outdated

Comment thread apps/desktop/src/main/index.ts

Comment thread apps/desktop/src/main/local-filesystem-grant-store.ts Outdated

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/desktop/desktop.tsx

waleedlatif1 force-pushed the codex/desktop-local-file-consent branch from cdb786e to 4cf15ef Compare October 9, 2026 02:18

vercel Bot temporarily deployed to Preview October 9, 2026 02:18 Inactive

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/desktop/desktop.tsx

Comment thread apps/desktop/native/directory.cc

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

waleedlatif1 added 8 commits October 8, 2026 19:32

fix(desktop): ask before accessing local files

65f729c

fix(desktop): remember folder permissions across chats

2b7f931

fix(desktop): cancel pending file consent and recheck access

260c7e6

fix(desktop): enumerate approved directory descriptors

436d535

fix(desktop): reject replaced directory listings

9d3e234

fix(desktop): share pending folder consent decisions

cab5ad9

fix(desktop): complete file consent and add full file access

16a4dce

fix(desktop): revalidate folder consent and preserve exact identities

5282735

waleedlatif1 force-pushed the codex/desktop-local-file-consent branch from 4cf15ef to 5282735 Compare October 9, 2026 02:33

vercel Bot temporarily deployed to Preview October 9, 2026 02:33 Inactive

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

waleedlatif1 merged commit dc39947 into staging Oct 9, 2026
51 checks passed

waleedlatif1 deleted the codex/desktop-local-file-consent branch October 9, 2026 04:08

Conversation

waleedlatif1 commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

waleedlatif1 commented Sep 26, 2026 •

edited

Loading

vercel Bot commented Sep 26, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading