Revert "fix(integrations): read every service mark from one registry" - #6707
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Integration & OAuth UI no longer resolves marks via Credential selectors inline Suggested actions pins Slack/Gmail with Copilot user input restores a large @-mention stack ( Smaller cleanups: table workflow-output column headers carry Reviewed by Cursor Bugbot for commit 651e38a. Configure here. |
Greptile SummaryThis PR reverts the centralized service-mark registry change, restoring prior icon mappings, tile rendering, OAuth presentation, and copilot mention utilities.
Confidence Score: 4/5The PR appears safe to merge from a runtime perspective, with non-blocking TypeScript and styling convention violations to address. No reachable functional or security failure was established, but the restored mention implementation uses pervasive explicit Files Needing Attention: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/constants.ts, apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-mention-data.ts, apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-mention-keyboard.ts, apps/sim/app/workspace/[workspaceId]/integrations/components/integrations-showcase/integrations-showcase.tsx
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/constants.ts | Restores the folder-driven mention and slash-command configuration, but uses an explicitly untyped generic item default. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-mention-data.ts | Restores mention data loading and workflow-block synchronization with several explicit any types and casts. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-mention-keyboard.ts | Restores keyboard navigation and dispatch for root, aggregated, and folder mention menus, while erasing folder item types. |
| apps/sim/app/workspace/[workspaceId]/integrations/components/integrations-showcase/integrations-showcase.tsx | Restores required explicit icon props and dynamic branded backgrounds, including prohibited inline styles. |
| apps/sim/lib/integrations/oauth-service.ts | Removes the OAuth-identity-to-integration-block bridge added by the reverted change. |
| packages/emcn/src/components/chip-modal/chip-modal.tsx | Narrows modal-header icons from rendered elements or component types back to component types only. |
Reviews (1): Last reviewed commit: "Revert "fix(integrations): read every se..." | Re-trigger Greptile
| title: string | ||
| /** Data source key in useMentionData return */ | ||
| dataKey: string | ||
| /** Loading state key in useMentionData return */ |
There was a problem hiding this comment.
Mention configuration erases item types
The restored mention-menu implementation uses explicit any types across folder configuration, data mapping, and insertion handlers. This prevents TypeScript from detecting mismatches between each folder's data, filter, context builder, and handler; use concrete item unions, generics, or unknown with type guards instead.
Context Used: TypeScript conventions and type safety (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
|
||
| if (!framed) { | ||
| return ( | ||
| <div |
There was a problem hiding this comment.
The restored integration and connector tiles apply dynamic backgrounds through JSX style props, bypassing the repository's required Tailwind styling convention. The same pattern occurs in the framed tile and the restored integration-detail and connector-card surfaces.
Context Used: Tailwind CSS and styling conventions (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reverts #6682