Skip to content

fix(icons): match folder icon optical size to sibling resource icons - #6692

Merged
waleedlatif1 merged 1 commit into
stagingfrom
worktree-fix+resource-folder-icon-size
Aug 14, 2026
Merged

fix(icons): match folder icon optical size to sibling resource icons#6692
waleedlatif1 merged 1 commit into
stagingfrom
worktree-fix+resource-folder-icon-size

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Folder icon read visibly smaller than the table/database icons next to it in resource rows (Tables, Files, Knowledge) despite an identical size-[14px] class — the class sets the SVG box, not the artwork inside it
  • The folder outline only spanned 15 units of the shared -1 -2 24 24 box vs 17.5–18 for its siblings
  • Scaled the outline to a 17-unit extent, snapped to the family's .25 grid with exact quarter-circle corner radii
  • Kept the body path byte-identical across Folder, FolderOpen and FolderCode so the sidebar expand/collapse toggle doesn't shift; FolderCode's brackets move with the body they're centred on

Artwork extents inside the shared box, after the change:

icon w h center
Table 19 18 10.25, 9.75
Database 15 17.5 10.25, 9.75
Folder 16.5 17 (was 15) 9, 9.75
FolderOpen 19 17 (was 15) 10.25, 9.75
FolderCode 16.5 17 (was 15) 9, 9.75

Type of Change

  • Bug fix

Testing

Verified the rendered path bounds numerically against the sibling icons (see table above) — all vertical centres stay at 9.75, the shared body path stays identical across the three folder variants, and the scaled artwork plus stroke stays inside the viewBox. Lint and type-check pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 14, 2026 2:48am

Request Review

@cursor

cursor Bot commented Aug 14, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Visual-only SVG path and comment changes in the emcn icon package; no runtime logic, auth, or data handling.

Overview
Fixes folder icons looking smaller than Table and Database in resource rows when all use the same size-* class—the class sizes the SVG box, not the drawn outline.

Folder, FolderOpen, and FolderCode now share one scaled body path (~17 units tall in the shared -1 -2 24 24 viewBox, on the family’s .25 grid with quarter-circle corners). FolderOpen’s open flap path is updated to stay aligned; FolderCode’s bracket strokes move with the body center. Doc comments explain optical sizing and that the three variants must stay in lockstep for sidebar expand/collapse toggles.

Reviewed by Cursor Bugbot for commit 3b7a517. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR enlarges and repositions the Folder icon family so its optical size matches sibling resource icons while preserving alignment between closed, open, and code variants.

  • Updates the shared folder-body geometry across all three icons.
  • Re-centers FolderCode brackets within the enlarged body.
  • Documents the optical-sizing and lockstep geometry requirements.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/emcn/src/icons/folder.tsx Enlarges the closed-folder outline within the existing viewBox without introducing clipping.
packages/emcn/src/icons/folder-open.tsx Mirrors the enlarged folder body and adjusts the open flap while preserving toggle alignment.
packages/emcn/src/icons/folder-code.tsx Applies the enlarged body and re-centers the code brackets within it.

Reviews (2): Last reviewed commit: "fix(icons): match folder icon optical si..." | Re-trigger Greptile

The folder icon read visibly smaller than the table/database icons beside
it in resource rows despite an identical size-[14px] class, because the
class sets the SVG box and not the artwork inside it. The folder outline
only spanned 15 units of the shared -1 -2 24 24 box against 17.5-18 for
its siblings.

Scale the outline to a 17-unit extent on the same .25 grid and quarter
circle corner radii, keeping the body path byte-identical across Folder,
FolderOpen and FolderCode so the sidebar expand/collapse toggle does not
shift. FolderCode's brackets move with the body they are centred on.
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3b7a517. Configure here.

@waleedlatif1
waleedlatif1 merged commit 9aa36a4 into staging Aug 14, 2026
21 of 24 checks passed
@waleedlatif1
waleedlatif1 deleted the worktree-fix+resource-folder-icon-size branch August 14, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant