fix(icons): match folder icon optical size to sibling resource icons - #6692
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Folder, FolderOpen, and FolderCode now share one scaled body path (~17 units tall in the shared Reviewed by Cursor Bugbot for commit 3b7a517. Configure here. |
Greptile SummaryThe PR enlarges and repositions the Folder icon family so its optical size matches sibling resource icons while preserving alignment between closed, open, and code variants.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/icons/folder.tsx | Enlarges the closed-folder outline within the existing viewBox without introducing clipping. |
| packages/emcn/src/icons/folder-open.tsx | Mirrors the enlarged folder body and adjusts the open flap while preserving toggle alignment. |
| packages/emcn/src/icons/folder-code.tsx | Applies the enlarged body and re-centers the code brackets within it. |
Reviews (2): Last reviewed commit: "fix(icons): match folder icon optical si..." | Re-trigger Greptile
The folder icon read visibly smaller than the table/database icons beside it in resource rows despite an identical size-[14px] class, because the class sets the SVG box and not the artwork inside it. The folder outline only spanned 15 units of the shared -1 -2 24 24 box against 17.5-18 for its siblings. Scale the outline to a 17-unit extent on the same .25 grid and quarter circle corner radii, keeping the body path byte-identical across Folder, FolderOpen and FolderCode so the sidebar expand/collapse toggle does not shift. FolderCode's brackets move with the body they are centred on.
194d41a to
3b7a517
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3b7a517. Configure here.
Summary
size-[14px]class — the class sets the SVG box, not the artwork inside it-1 -2 24 24box vs 17.5–18 for its siblings.25grid with exact quarter-circle corner radiiFolder,FolderOpenandFolderCodeso the sidebar expand/collapse toggle doesn't shift;FolderCode's brackets move with the body they're centred onArtwork extents inside the shared box, after the change:
TableDatabaseFolderFolderOpenFolderCodeType of Change
Testing
Verified the rendered path bounds numerically against the sibling icons (see table above) — all vertical centres stay at 9.75, the shared body path stays identical across the three folder variants, and the scaled artwork plus stroke stays inside the viewBox. Lint and type-check pass.
Checklist