fix(sidebar): align credits chip with panel toggle and square the collapsed rail - #6691
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview A shared Sidebar expand flash is fixed by giving the header Search/Collapse cluster explicit widths ( On the home empty state, the credits chip uses the same overlay header geometry as the resource panel toggle: 1px gap to the 30px toggle when collapsed, standard end inset when open, with a right position transition. Resource expand/collapse and activity clearing are consolidated into Reviewed by Cursor Bugbot for commit afe5df9. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR standardizes collapsed-sidebar chip geometry, synchronizes the header-control cluster with sidebar animation, and aligns resource-header controls through shared positioning constants.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The explicit control widths match the rendered chip geometry, hover-peek removes the collapsed-width constraint before showing labels, and the resource-panel refactor preserves the existing state transitions.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-tabs/resource-tab-controls.ts | Consolidates resource-header control geometry into shared overlay and toggle-size constants. |
| apps/sim/app/workspace/[workspaceId]/home/home.tsx | Reuses resource-activity cleanup and animates the credits chip between collapsed and expanded panel positions. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/constants.ts | Defines shared width-transition geometry for icon-only controls in the collapsed sidebar rail. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx | Applies collapsed chip sizing and explicit header-control widths synchronized with sidebar animation. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/sidebar-footer/sidebar-footer.tsx | Applies the shared collapsed-rail geometry to profile and help controls. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-sidebar/settings-sidebar.tsx | Applies uniform collapsed-rail sizing to settings navigation controls. |
Reviews (1): Last reviewed commit: "fix(sidebar): align credits chip with pa..." | Re-trigger Greptile
…hifting on toggle
Summary
SIDEBAR_WIDTH.COLLAPSED) move togetherw-0toauto, momentarily crushing the flex-1 workspace chip to zero and landing the hover-filled Search chip exactly under the cursor. Both width endpoints are now explicit so the cluster tweens in step with the railoverlaygeometry class replaces the per-callsitecontentTop/controlsmagic offsets, the toggle size is a shared CSS var, duplicated resource-activity Set-pruning is extracted into one helper, and the toggle's inline expand closure is a named handlerType of Change
Testing
Tested manually. Verified the expand animation frame-by-frame with a Playwright geometry probe: before, the Search chip jumped to the workspace icon's position with a hover fill at the click frame; after, it stays right of the workspace chip through the whole animation. Sidebar store tests pass. Lint, type-check, and check:audits pass.
Checklist
🤖 Generated with Claude Code