Skip to content

fix(blocks): give the detail headers the same tile as everything else - #6672

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/snapshot-block-tile
Aug 13, 2026
Merged

fix(blocks): give the detail headers the same tile as everything else#6672
waleedlatif1 merged 1 commit into
stagingfrom
fix/snapshot-block-tile

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The tile consolidation left the large detail headers on their own treatment, so a block wore one colour on the canvas and another in the header naming it — the preview panel behind the deploy modal and the logs trace detail painted straight from the catalog bgColor (Start's catalog blue over a neutral card), and hardcoded #2FB3FF/#FEE12B for the two subflows
  • Adds the 18px header slot to BlockTile and points all three headers at it: preview panel, trace detail, and the editor header — which had been carrying its own inline copy of the accent rule
  • WorkflowTypeIcon takes an icon class so the accent chip can draw the larger glyph the header uses
  • Drops the two duplicate local IconComponent helpers the headers were the last callers of

Type of Change

  • Bug fix

Testing

Type-check and lint clean across apps/sim and packages/workflow-renderer; blocks/ suite passes (706 tests).

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The tile consolidation left the large detail headers on their own treatment,
so a block wore one colour on the canvas and another in the header naming it:
the preview panel behind the deploy modal and the logs trace detail both
painted straight from the catalog `bgColor`, showing Start's catalog blue over
a neutral card, and hardcoded `#2FB3FF`/`#FEE12B` for the two subflows.

Adds the 18px header slot to `BlockTile` and points all three headers at it —
preview panel, trace detail, and the editor header, which had been carrying its
own inline copy of the accent rule. `WorkflowTypeIcon` takes an icon class so
the accent chip can draw the larger glyph the header uses.
@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 13, 2026 7:27pm

Request Review

@cursor

cursor Bot commented Aug 13, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only consolidation of block icon rendering with no auth, data, or execution logic changes.

Overview
Detail headers in the editor, preview panel, and logs trace detail no longer paint block icons from catalog bgColor, hardcoded subflow colors, or inline accent/ChipTag logic — they now use BlockTile with a new lg (18px) slot so the same accent vs provider treatment as the canvas and list rows applies.

BlockTile adds lg sizing and per-size icon classes; accent blocks pass iconClassName through to WorkflowTypeIcon. Local IconComponent helpers and related imports are removed from the editor and preview editor.

Reviewed by Cursor Bugbot for commit f5d74c0. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR consolidates detail-header icon rendering onto the shared BlockTile treatment.

  • Adds an 18px header tile size with a corresponding 12px glyph size.
  • Uses the shared tile in the editor, preview, and trace-detail headers.
  • Allows WorkflowTypeIcon callers to override the glyph size.
  • Removes duplicated local icon-rendering helpers and hardcoded subflow colors.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/blocks/block-tile.tsx Adds the large tile and glyph sizing variants while preserving the established single-consumer component configuration pattern.
packages/workflow-renderer/src/workflow-block/workflow-block-view.tsx Adds an optional glyph class override to WorkflowTypeIcon without changing its default rendering.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/editor.tsx Replaces the editor header’s inline accent-chip implementation with the shared large BlockTile.
apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-editor/preview-editor.tsx Uses the shared large tile for standard and subflow preview headers and removes duplicated icon rendering.
apps/sim/app/workspace/[workspaceId]/logs/components/log-details/components/trace-view/trace-view.tsx Uses the shared large tile for trace details while retaining the existing resolved icon and contrast-adjusted color inputs.

Reviews (2): Last reviewed commit: "fix(blocks): give the detail headers the..." | Re-trigger Greptile

Comment thread apps/sim/blocks/block-tile.tsx
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f5d74c0. Configure here.

@waleedlatif1
waleedlatif1 merged commit 85c8451 into staging Aug 13, 2026
24 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/snapshot-block-tile branch August 13, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant