Skip to content

improvement(updates): validate update path and fix native mac help - #6580

Merged
Sg312 merged 2 commits into
stagingfrom
improvement-desktop-4
Aug 12, 2026
Merged

improvement(updates): validate update path and fix native mac help#6580
Sg312 merged 2 commits into
stagingfrom
improvement-desktop-4

Conversation

@Sg312

@Sg312 Sg312 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix native mac help

Type of Change

  • Bug fix

Testing

Manual

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 12, 2026 2:12am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds native macOS Help documentation search and routes the desktop View > Search command to the workspace search modal.

  • Builds and packages a universal macOS Node-API/AppKit search provider.
  • Registers and cleans up the provider with the Electron lifecycle.
  • Adds a typed open-search desktop command and Mod+K menu action.
  • Adds bridge and menu unit coverage.

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or independently actionable non-blocking defects identified.

The native provider is platform-gated, packaged at its resolved runtime path, validates remote URLs, cancels superseded work, and is cleaned up idempotently; the new search command is consistently represented across the main process, preload transport, shared type, and workspace listener.

Important Files Changed

Filename Overview
apps/desktop/native/help-search.mm Implements a bounded, cancellable AppKit Help search provider with endpoint and result URL validation.
apps/desktop/scripts/build.ts Compiles the native provider as a universal macOS Node-API bundle while leaving non-macOS builds portable.
apps/desktop/src/main/help-search.ts Loads, validates, installs, and safely uninstalls the optional native bridge.
apps/desktop/src/main/index.ts Integrates Help provider lifecycle management and routes the search menu command to the main renderer.
apps/desktop/src/main/menu.ts Adds View > Search with the Mod+K accelerator and delegates activation through injected menu dependencies.
apps/sim/app/workspace/[workspaceId]/components/workspace-chrome/workspace-chrome.tsx Handles the new desktop command by mirroring the existing search-modal toggle behavior.
packages/desktop-bridge/src/index.ts Extends the shared desktop command contract with the additive open-search command.

Sequence Diagram

sequenceDiagram
  participant User
  participant Menu as Electron Menu
  participant Main as Desktop Main Process
  participant Bridge as Preload Bridge
  participant Workspace as WorkspaceChrome
  participant Modal as Search Modal Store
  participant Help as Native Help Provider
  participant Docs as docs.sim.ai

  User->>Menu: Press Mod+K
  Menu->>Main: openSearch()
  Main->>Bridge: desktop:command(open-search)
  Bridge->>Workspace: onCommand(open-search)
  Workspace->>Modal: Toggle search modal

  User->>Help: Search macOS Help
  Help->>Docs: GET /api/search
  Docs-->>Help: Documentation results
  Help-->>User: Native Help items
Loading

Reviews (1): Last reviewed commit: "Desktop update check" | Re-trigger Greptile

@Sg312
Sg312 merged commit 2a5e29a into staging Aug 12, 2026
28 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement-desktop-4 branch August 12, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant