improvement(desktop): help menu - #6576
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR updates the desktop Help menu’s status label and standardizes dropdown cursor, selected, and submenu-open surfaces.
Confidence Score: 5/5The PR appears safe to merge, with the updated dropdown states preserving existing navigation and selection behavior. The desktop change is label-only, while the dropdown changes consistently distinguish transient cursor highlighting from persistent selected or open states without leaving a reachable functional failure.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/components/dropdown-menu/dropdown-menu.tsx | Centralizes instantaneous hover highlighting and persistent selected styling, adding an active prop without an identified behavioral regression. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/collapsed-sidebar-menu/collapsed-sidebar-menu.tsx | Migrates current-route and open-action rows to the shared selected-state API and relies on the shared submenu-trigger styling. |
| apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/add-resource-dropdown/add-resource-dropdown.tsx | Changes the manually tracked search cursor from the selected surface to the transient hover surface. |
| apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/plus-menu-dropdown/plus-menu-dropdown.tsx | Aligns the manually tracked resource cursor with shared hover styling and removes transition lag. |
| apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/skills-menu-dropdown/skills-menu-dropdown.tsx | Aligns the manually tracked skills cursor with shared hover styling and removes transition lag. |
| apps/desktop/src/main/menu.ts | Renames the status-link label while preserving its URL and click behavior. |
| apps/desktop/src/main/menu.test.ts | Updates the Help-menu assertion for the renamed status label. |
Reviews (1): Last reviewed commit: "Update help menu in desktop" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Help menu update
Type of Change
Testing
Manual
Checklist