Skip to content

improvement(desktop): help menu - #6576

Merged
Sg312 merged 1 commit into
stagingfrom
improvement-desktop-2
Aug 12, 2026
Merged

improvement(desktop): help menu#6576
Sg312 merged 1 commit into
stagingfrom
improvement-desktop-2

Conversation

@Sg312

@Sg312 Sg312 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Help menu update

Type of Change

  • Bug fix

Testing

Manual

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 12, 2026 1:06am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates the desktop Help menu’s status label and standardizes dropdown cursor, selected, and submenu-open surfaces.

  • Renames “System Status” to “Sim Status” and updates its test.
  • Adds shared hover and selected row styles to the EMCN dropdown component.
  • Migrates collapsed-sidebar current-item styling to the new active prop.
  • Uses the hover surface for transient keyboard and pointer cursors in search-backed menus.

Confidence Score: 5/5

The PR appears safe to merge, with the updated dropdown states preserving existing navigation and selection behavior.

The desktop change is label-only, while the dropdown changes consistently distinguish transient cursor highlighting from persistent selected or open states without leaving a reachable functional failure.

Important Files Changed

Filename Overview
packages/emcn/src/components/dropdown-menu/dropdown-menu.tsx Centralizes instantaneous hover highlighting and persistent selected styling, adding an active prop without an identified behavioral regression.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/collapsed-sidebar-menu/collapsed-sidebar-menu.tsx Migrates current-route and open-action rows to the shared selected-state API and relies on the shared submenu-trigger styling.
apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/add-resource-dropdown/add-resource-dropdown.tsx Changes the manually tracked search cursor from the selected surface to the transient hover surface.
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/plus-menu-dropdown/plus-menu-dropdown.tsx Aligns the manually tracked resource cursor with shared hover styling and removes transition lag.
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/skills-menu-dropdown/skills-menu-dropdown.tsx Aligns the manually tracked skills cursor with shared hover styling and removes transition lag.
apps/desktop/src/main/menu.ts Renames the status-link label while preserving its URL and click behavior.
apps/desktop/src/main/menu.test.ts Updates the Help-menu assertion for the renamed status label.

Reviews (1): Last reviewed commit: "Update help menu in desktop" | Re-trigger Greptile

@Sg312
Sg312 merged commit e7590c8 into staging Aug 12, 2026
29 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement-desktop-2 branch August 12, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant