Skip to content

fix(mship): update failing tests - #6548

Closed
j15z wants to merge 1 commit into
stagingfrom
fix/lint-failure
Closed

fix(mship): update failing tests#6548
j15z wants to merge 1 commit into
stagingfrom
fix/lint-failure

Conversation

@j15z

@j15z j15z commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Update failing CI tests for cmdk

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

CI now passes

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 11, 2026 6:16pm

Request Review

@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only expectation updates with no runtime behavior changes.

Overview
Updates SearchModal tests so expected cmdk row text matches the current ask-mode label format.

Assertions that previously expected New Chat: … now expect New chat: … (lowercase “chat”) in the Tab-to-ask flows for a full query and for toggling back to search results. No production code changes in this diff—only test expectations aligned with existing UI copy in search-modal.tsx.

Reviewed by Cursor Bugbot for commit f462d96. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates two stale SearchModal test expectations to match the current sentence-case “New chat” label.

  • Aligns the ask-mode handoff test with the rendered label.
  • Aligns the return-to-search-results test with the same label.

Confidence Score: 5/5

The PR appears safe to merge because both test expectation updates accurately reflect the component’s current rendered text.

The changes only correct stale capitalization in two assertions while preserving validation of ask-mode transitions and query handoff behavior.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.test.tsx Both assertion-only changes correctly match the SearchModal’s current New chat: <query> output without weakening behavior coverage.

Reviews (1): Last reviewed commit: "fix(mship): update failing tests" | Re-trigger Greptile

@j15z j15z closed this Aug 11, 2026
@waleedlatif1
waleedlatif1 deleted the fix/lint-failure branch August 11, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant