feat(workflow-renderer): extract edge, subflow, and note Views into @sim/workflow-renderer#5263
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Editor note, subflow, and edge components are reduced to containers that read stores and permissions, resolve diff/run/focus state, and pass it into the views—
Reviewed by Cursor Bugbot for commit 777ee74. Configure here. |
Greptile SummaryThis PR moves shared workflow rendering into a new package. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "feat(workflow-renderer): extract edge, s..." | Re-trigger Greptile |
a670e69 to
460fbf5
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 460fbf5. Configure here.
|
@greptile re-review — the flagged |
…sim/workflow-renderer Adds a @sim/workflow-renderer package with pure, props-driven WorkflowEdgeView, SubflowNodeView, and NoteBlockView shared by the editor and (future) docs preview. Moves block-dimensions constants into the package. Each editor node becomes a thin Container that wires stores/permissions and injects the editor-only ActionBar via a slot. No optimizePackageImports for the workspace component packages (avoids the toast-style module duplication); Tailwind scans the package source.
460fbf5 to
777ee74
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 777ee74. Configure here.
Summary
First step of the shared workflow renderer: a
@sim/workflow-rendererpackage holding pure, props-driven Views that the editor and the (future) docs preview both render.WorkflowEdgeView,SubflowNodeView,NoteBlockView— pure renderers with no store/socket/permission coupling. Each editor node becomes a thin Container that wires stores + permissions and injects the editor-onlyActionBarthrough a slot.dimensions.ts); rewrites the importers to@sim/workflow-renderer.next.config: both@sim/emcnand@sim/workflow-rendererintranspilePackages, neither inoptimizePackageImports(avoids the toast-style module duplication). Tailwind scans both package sources.Visual output is unchanged — the editor renders the same markup; the View is just where it now lives.
Type of Change
Testing
apps/simtypecheck 0 errors;@sim/workflow-renderer+@sim/emcntypecheck 0; monorepo boundaries + biome clean.Checklist