Skip to content

chore(deploy): remove deploy as a2a#5255

Merged
icecrasher321 merged 2 commits into
stagingfrom
chore/remove-a2a
Jun 29, 2026
Merged

chore(deploy): remove deploy as a2a#5255
icecrasher321 merged 2 commits into
stagingfrom
chore/remove-a2a

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Cleanup deploy as A2A. Update block to latest version of protocol.

Type of Change

  • Other: Code Cleanup

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@icecrasher321 icecrasher321 requested a review from a team as a code owner June 28, 2026 22:53
@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 29, 2026 2:53am

Request Review

@cursor

cursor Bot commented Jun 28, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Large removal of public A2A serve endpoints and deploy UI is a breaking change for anyone exposing workflows as A2A agents; remaining tool route behavior and response shapes also changed.

Overview
This PR drops “deploy as A2A” as a workflow deployment surface. The agent management and JSON-RPC serve APIs under /api/a2a/agents and /api/a2a/serve, the deploy modal A2A tab (A2aDeploy), and related UI hooks are deleted. Docs and product copy no longer describe A2A as a deployment channel (deploy modal tabs, enterprise Deploy Tabs, logs trigger lists, etc.).

The A2A integration block for talking to external agents stays, but the tool layer is trimmed and consolidated: push-notification, resubscribe, and related routes are removed; send message, get/cancel task, and get agent card now go through @/lib/a2a/client with clearer outputs, 502 errors from upstream agents, and file attachments on send (storage access + size limits).

Documentation moves from per-locale tools/a2a pages to en/integrations/a2a, documenting only the four remaining tools (no push/resubscribe). Locale tool pages and the docs A2AIcon export are removed.

Reviewed by Cursor Bugbot for commit 790f04b. Configure here.

@greptile-apps

greptile-apps Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the A2A deployment surface while keeping A2A as an external-agent block. The main changes are:

  • Removed A2A serve routes, deploy UI, lifecycle cleanup, and database tables.
  • Re-added the A2A block with send, get task, cancel task, and get agent card operations.
  • Updated workflow trigger contracts, logs filters, docs, and generated metadata.

Confidence Score: 4/5

This is close, but the legacy A2A operation path should be fixed before merging.

  • Saved workflows can still contain removed A2A operation ids.
  • The updated block passes those ids directly to the executor.
  • The affected workflow fails with a missing-tool error instead of a controlled unsupported-operation result.

apps/sim/blocks/blocks/a2a.ts

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/a2a.ts Re-adds the A2A block with fewer operations, but persisted removed operation ids can still be serialized into missing tools.
packages/db/migrations/0252_remove_a2a.sql Drops serve-side A2A persistence and the deprecated usage counter.
apps/sim/lib/api/contracts/workflows.ts Removes a2a from the workflow trigger type contract.

Reviews (2): Last reviewed commit: "add block" | Re-trigger Greptile

Comment thread apps/sim/blocks/blocks/a2a.ts
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

bugbot run

@icecrasher321 icecrasher321 changed the title chore(deploy): remove a2a chore(deploy): remove deploy as a2a Jun 29, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 790f04b. Configure here.

Comment thread apps/sim/blocks/blocks/a2a.ts
@icecrasher321 icecrasher321 merged commit c596316 into staging Jun 29, 2026
18 checks passed
@waleedlatif1 waleedlatif1 deleted the chore/remove-a2a branch June 29, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant