perf(dev): curate SIM_DEV_MINIMAL_REGISTRY to core toolbar blocks#5251
perf(dev): curate SIM_DEV_MINIMAL_REGISTRY to core toolbar blocks#5251TheodoreSpeaks wants to merge 1 commit into
Conversation
Rebuild the dev-only minimal block registry from the canonical, toolbar-visible core (category blocks/triggers, not hideFromToolbar, latest version). Adds the visible workflow_input and table blocks (previously only the hidden `workflow` was present, so the Workflow block never rendered in dev:minimal), drops the superseded/hidden entries (api_trigger, chat_trigger, input_trigger, manual_trigger, router, starter, workflow), and hand-prunes the heaviest / rarely-core-dev blocks (mothership, pi, tts, stt_v2, image_generator_v2, video_generator_v3, circleback). Dev-only, gated on SIM_DEV_MINIMAL_REGISTRY=1; never aliased in production. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Swaps and fixes: Supabase entries ( Net result is 32 dev-only registry keys; production still uses the full Reviewed by Cursor Bugbot for commit 4a31cd1. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
@greptile review |
Greptile SummaryThis PR updates the dev-only minimal block registry. The main changes are:
Confidence Score: 4/5The dev minimal registry can break older saved workflows that still use legacy block IDs.
apps/sim/blocks/registry-maps.minimal.ts Important Files Changed
Reviews (1): Last reviewed commit: "perf(dev): curate SIM_DEV_MINIMAL_REGIST..." | Re-trigger Greptile |
| router_v2: RouterV2Block, | ||
| rss: RssBlock, | ||
| schedule: ScheduleBlock, | ||
| search: SearchBlock, | ||
| sim_workspace_event: SimWorkspaceEventBlock, | ||
| start_trigger: StartTriggerBlock, | ||
| starter: StarterBlock, | ||
| table: TableBlock, | ||
| translate: TranslateBlock, | ||
| variables: VariablesBlock, | ||
| workflow: WorkflowBlock, | ||
| wait: WaitBlock, | ||
| webhook_request: WebhookRequestBlock, | ||
| workflow_input: WorkflowInputBlock, |
There was a problem hiding this comment.
When SIM_DEV_MINIMAL_REGISTRY=1 opens a saved workflow containing router, workflow, starter, or the older trigger types, getBlock(type) can no longer resolve the persisted type and the serializer throws Invalid block type. The executor still recognizes those IDs and there is no load-time type migration, so older dev workflows can fail to open or save in minimal mode.
Greptile SummaryThis PR curates the dev-only minimal block registry. The main changes are:
Confidence Score: 4/5The minimal dev registry can stop resolving existing workflows that still store legacy block ids.
apps/sim/blocks/registry-maps.minimal.ts Important Files Changed
Reviews (2): Last reviewed commit: "perf(dev): curate SIM_DEV_MINIMAL_REGIST..." | Re-trigger Greptile |
| rss: RssBlock, | ||
| schedule: ScheduleBlock, | ||
| search: SearchBlock, | ||
| sim_workspace_event: SimWorkspaceEventBlock, |
There was a problem hiding this comment.
Legacy Block Types Stop Resolving
When SIM_DEV_MINIMAL_REGISTRY=1 loads a saved or fixture workflow that still stores starter, router, workflow, or the removed trigger ids, persistence keeps those block type values and later registry validation cannot resolve them. Existing dev:minimal workflows can then fail validation or execution instead of loading through a compatibility alias or block-type migration.
Summary
SIM_DEV_MINIMAL_REGISTRY=1/bun run dev:minimal) from the canonical, toolbar-visible core set: everycategory: 'blocks'/'triggers'block that is nothideFromToolbar, always the latest version.workflow_inputandtableblocks. Previously only the hiddenworkflowblock was in the minimal set, so the Workflow block never rendered indev:minimaleven though it shows in a full build.api_trigger,chat_trigger,input_trigger,manual_trigger(folded intostart_trigger),router(→router_v2),starter(→start_trigger),workflow(→workflow_input).mothership,pi,tts,stt_v2,image_generator_v2,video_generator_v3,circleback.category: 'tools'integrations remain excluded — that heavy graph is what minimal mode exists to skip. Net set: 32 curated core blocks.Type of Change
Testing
Tested manually:
dev:minimaltoolbar now shows the Workflow block; every imported block export resolves against current staging;bunx biome checkclean on the file. Dev-only — gated onSIM_DEV_MINIMAL_REGISTRY=1, never aliased in production.Checklist