Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • improved mcp sse events notifs, should always used deployed state when reading inputs
    • added ability to edit existing mcp tools
  • update jira to handle files with an includeAttachments flag,
  • fix UI inconsistencies in settings modal for skills tab
  • fix org and workspace invitations when bundled, gracefully handles when the invitee is already apart of the workspace
  • redact sensitive data from logs before persisting them on the server
  • remove unnecessary use effects

Type of Change

  • Bug fix
  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…le files, fix UI issues in settings modal, fix org and workspace invitations when bundled
@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 11, 2026 1:08am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR implements several improvements and bug fixes across MCP tooling, Jira integration, UI components, and security:

MCP Improvements:

  • MCP tools now use deployed workflow state instead of current editor state when generating parameter schemas, ensuring consistency between what's deployed and what's exposed via MCP
  • Added SSE notifications (publishWorkflowToolsChanged) when MCP tools are created, updated, or deleted, enabling real-time UI updates
  • Implemented full edit functionality for MCP servers in the settings modal with connection testing and validation
  • Improved MCP deployment modal to support adding/removing server selections and better differentiate between configuration vs selection changes

Jira Enhancements:

  • Added includeAttachments flag to download and include actual attachment file contents (base64-encoded) in Jira tool responses
  • Added convenience fields (authorName, statusName, assigneeName) to Jira responses for easier consumption without needing to traverse nested objects

Security:

  • Implemented sensitive data redaction in block execution logs using redactApiKeys() before persisting to the server, protecting API keys, tokens, passwords, and other credentials

Bug Fixes:

  • Fixed workspace invitation acceptance to update existing permissions instead of failing when the invitee already has workspace access
  • Fixed UI inconsistencies in skills settings tab by removing conditional disabled styling on search input
  • Removed unnecessary useMcpToolsEvents hook calls that were redundant

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are well-structured improvements and bug fixes. The MCP improvements use deployed state correctly, the Jira attachment handling is properly implemented with error handling, the invitation fix gracefully handles duplicate permissions, and the log redaction enhances security. No breaking changes or risky patterns detected.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/lib/mcp/workflow-mcp-sync.ts Improved MCP tool synchronization to use deployed state instead of current state, and added SSE notifications for tool changes
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/mcp/mcp.tsx Added complete edit modal functionality for MCP servers with form validation, connection testing, and state management
apps/sim/tools/jira/utils.ts Added downloadJiraAttachments function to download and base64-encode attachment file contents
apps/sim/tools/jira/retrieve.ts Added includeAttachments parameter to download attachment files and include them in the response
apps/sim/executor/execution/block-executor.ts Added redaction of sensitive data in logs using redactApiKeys before persisting inputs
apps/sim/app/api/organizations/[id]/invitations/[invitationId]/route.ts Fixed workspace invitation acceptance to update existing permissions instead of failing when user already has access
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/mcp/mcp.tsx Improved server selection management to support adding/removing servers and better track configuration vs selection changes

Sequence Diagram

sequenceDiagram
    participant User
    participant UI as MCP Settings UI
    participant API as MCP API
    participant Sync as workflow-mcp-sync
    participant Deploy as Deployed State
    participant PubSub as SSE PubSub
    participant Clients as Connected Clients

    User->>UI: Create/Update MCP Tool
    UI->>API: POST /api/mcp/workflow-servers/[id]/tools
    API->>Deploy: generateParameterSchemaForWorkflow(workflowId)
    Deploy->>Deploy: loadDeployedWorkflowState()
    Deploy->>Deploy: generateSchemaFromBlocks()
    Deploy-->>API: parameterSchema
    API->>API: Insert/Update workflowMcpTool
    API->>PubSub: publishWorkflowToolsChanged(serverId, workspaceId)
    PubSub-->>Clients: SSE: tools_changed event
    Clients->>Clients: Invalidate MCP tools cache
    API-->>UI: Success response
    
    Note over User,Clients: Workflow State Changes
    User->>User: Deploy/Undeploy Workflow
    User->>Sync: syncMcpToolsForWorkflow()
    Sync->>Deploy: loadDeployedWorkflowState()
    Deploy-->>Sync: deployedState
    Sync->>Sync: generateSchemaFromBlocks()
    Sync->>Sync: Update all tools for workflow
    Sync->>PubSub: publishWorkflowToolsChanged()
    PubSub-->>Clients: SSE: tools_changed event
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1
Copy link
Collaborator Author

@cursor review

@waleedlatif1
Copy link
Collaborator Author

@cursor review

@waleedlatif1
Copy link
Collaborator Author

@cursor review

@waleedlatif1
Copy link
Collaborator Author

@cursor review

@waleedlatif1
Copy link
Collaborator Author

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@waleedlatif1 waleedlatif1 merged commit 6d16f21 into staging Feb 11, 2026
5 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/jira branch February 11, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant