-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(mcp): improved mcp sse events notifs, update jira to handle files, fix UI issues in settings modal, fix org and workspace invitations when bundled #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…le files, fix UI issues in settings modal, fix org and workspace invitations when bundled
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR implements several improvements and bug fixes across MCP tooling, Jira integration, UI components, and security: MCP Improvements:
Jira Enhancements:
Security:
Bug Fixes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant UI as MCP Settings UI
participant API as MCP API
participant Sync as workflow-mcp-sync
participant Deploy as Deployed State
participant PubSub as SSE PubSub
participant Clients as Connected Clients
User->>UI: Create/Update MCP Tool
UI->>API: POST /api/mcp/workflow-servers/[id]/tools
API->>Deploy: generateParameterSchemaForWorkflow(workflowId)
Deploy->>Deploy: loadDeployedWorkflowState()
Deploy->>Deploy: generateSchemaFromBlocks()
Deploy-->>API: parameterSchema
API->>API: Insert/Update workflowMcpTool
API->>PubSub: publishWorkflowToolsChanged(serverId, workspaceId)
PubSub-->>Clients: SSE: tools_changed event
Clients->>Clients: Invalidate MCP tools cache
API-->>UI: Success response
Note over User,Clients: Workflow State Changes
User->>User: Deploy/Undeploy Workflow
User->>Sync: syncMcpToolsForWorkflow()
Sync->>Deploy: loadDeployedWorkflowState()
Deploy-->>Sync: deployedState
Sync->>Sync: generateSchemaFromBlocks()
Sync->>Sync: Update all tools for workflow
Sync->>PubSub: publishWorkflowToolsChanged()
PubSub-->>Clients: SSE: tools_changed event
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, no comments
...components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx
Show resolved
Hide resolved
...orkflowId]/components/panel/components/deploy/components/deploy-modal/components/mcp/mcp.tsx
Show resolved
Hide resolved
|
@cursor review |
...orkflowId]/components/panel/components/deploy/components/deploy-modal/components/mcp/mcp.tsx
Show resolved
Hide resolved
...orkspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/mcp/mcp.tsx
Show resolved
Hide resolved
...orkspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/mcp/mcp.tsx
Show resolved
Hide resolved
apps/sim/app/api/organizations/[id]/invitations/[invitationId]/route.ts
Outdated
Show resolved
Hide resolved
|
@cursor review |
|
@cursor review |
.../components/sidebar/components/settings-modal/components/team-management/team-management.tsx
Outdated
Show resolved
Hide resolved
...orkflowId]/components/panel/components/deploy/components/deploy-modal/components/mcp/mcp.tsx
Outdated
Show resolved
Hide resolved
|
@cursor review |
...orkspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/mcp/mcp.tsx
Show resolved
Hide resolved
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Summary
includeAttachmentsflag,Type of Change
Testing
Tested manually
Checklist