Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

Summary

Adds the AgentSkillsIcon and a consistent purple background color to skill entries in the logs' trace spans. Previously, skill entries appeared with a generic gray icon due to missing specific handling for the load_skill tool.

Fixes # (issue) - No specific issue number provided, remove if not applicable

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

The change was verified by running lint and type checks, which passed successfully. Visual inspection confirms the icon and color are now displayed correctly for skill blocks in the logs.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos


Open in Cursor Open in Web

Adds the AgentSkillsIcon to trace spans in logs when displaying the
load_skill tool. Previously, skills appeared with a default gray color.
Now they display with the proper skill icon and a purple (#8B5CF6)
background color, consistent with the skills icon used in the settings
modal and skill input components.

Co-authored-by: Emir Karabeg <emir-karabeg@users.noreply.github.com>
@cursor
Copy link

cursor bot commented Feb 10, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 10, 2026 7:54pm

Request Review

@waleedlatif1 waleedlatif1 changed the title Logs skill icon improvement(logs): skill icon for tool call Feb 10, 2026
@waleedlatif1 waleedlatif1 marked this pull request as ready for review February 10, 2026 20:37
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

Added special handling for the load_skill tool in trace spans to display it with the AgentSkillsIcon and a purple background color (#8B5CF6). Previously, skill entries appeared with a generic gray icon because load_skill is not registered in the block registry. The change follows the existing pattern for special tool types like loop, parallel, and workflow that also have custom icon/color configurations outside the registry.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, focused addition that follows established patterns in the codebase. It adds special handling for the load_skill tool (lines 122-123) using the same approach as other special types like loop, parallel, and workflow. The icon is properly imported and exists in the codebase, and the color value (#8B5CF6) is a standard purple/violet color used elsewhere. No logic changes, no breaking changes, and no security concerns.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/logs/components/log-details/components/trace-spans/trace-spans.tsx Added special handling for load_skill tool to display AgentSkillsIcon with purple background (#8B5CF6) in trace spans

Sequence Diagram

sequenceDiagram
    participant TraceSpan
    participant getBlockIconAndColor
    participant Registry as Block Registry
    participant Icons
    
    TraceSpan->>getBlockIconAndColor: Request icon & color for span type
    
    alt type === 'tool' && toolName
        alt toolName === 'load_skill'
            getBlockIconAndColor->>Icons: Get AgentSkillsIcon
            Icons-->>getBlockIconAndColor: Return icon
            getBlockIconAndColor-->>TraceSpan: {icon: AgentSkillsIcon, bgColor: '#8B5CF6'}
        else other tool names
            getBlockIconAndColor->>Registry: getBlockByToolName(toolName)
            Registry-->>getBlockIconAndColor: Return block config
            getBlockIconAndColor-->>TraceSpan: {icon, bgColor} from block
        end
    else Special types (loop, parallel, workflow)
        getBlockIconAndColor-->>TraceSpan: {icon, bgColor} from special config
    else Standard block types
        getBlockIconAndColor->>Registry: getBlock(blockType)
        Registry-->>getBlockIconAndColor: Return block config
        getBlockIconAndColor-->>TraceSpan: {icon, bgColor} from block
    end
    
    TraceSpan->>TraceSpan: Render icon with background color
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 73540e3 into staging Feb 10, 2026
11 checks passed
@waleedlatif1 waleedlatif1 deleted the cursor/logs-skill-icon-682e branch February 10, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants