-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(timeouts): files/base64 should use max timeouts + auth centralization #3179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR centralizes file download timeouts by switching several call sites from fixed 180s defaults to higher/max execution timeouts. Specifically, it increases the job status endpoint’s The main concern is that Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant FU as file-utils.server.ts
participant DV as input-validation.server
participant Fetch as secureFetchWithPinnedIP
participant Storage as storage-service
Caller->>FU: downloadFileFromUrl(fileUrl, timeoutMs?)
alt Internal file URL
FU->>Storage: downloadFile({key, context})
Storage-->>FU: Buffer
FU-->>Caller: Buffer
else External URL
FU->>DV: validateUrlWithDNS(fileUrl)
DV-->>FU: {isValid, resolvedIP}
FU->>Fetch: secureFetchWithPinnedIP(url, resolvedIP, {timeout})
Fetch-->>FU: Response
FU-->>Caller: Buffer
end
Note over FU: PR sets default timeoutMs = getMaxExecutionTimeout()
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 1 comment
Additional Comments (1)
|
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
|
@cursor review |
|
bugbot run |
|
bugbot run |
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Summary
Type of Change
Testing
Tested manually
Checklist