-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(preview): added trigger mode context for deploy preview #3177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR updates the deploy preview sidebar to derive a block’s “trigger-mode context” and filter subblocks accordingly (including a special-case for legacy It also adjusts the Key integration surface: PreviewEditorContent’s subblock visibility now depends on Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Preview as PreviewEditorContent
participant TriggerUtils as TriggerUtils.isTriggerBlock
participant Blocks as getBlock(type)
participant Editor as useEditorSubblockLayout
Preview->>Blocks: getBlock(block.type)
Preview->>TriggerUtils: isTriggerBlock(block)
TriggerUtils->>Blocks: getBlock(block.type)
TriggerUtils-->>Preview: effectiveTrigger (bool)
Preview-->>Preview: filter subBlocks (trigger-config/mode)
Editor-->>Editor: uses displayTriggerMode (from UI state)
Editor-->>Editor: filter subBlocks (mode/trigger-config)
Note over Preview,Editor: Preview and Editor may compute different trigger context
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
...pp/workspace/[workspaceId]/w/components/preview/components/preview-editor/preview-editor.tsx
Show resolved
Hide resolved
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
...mponents/panel/components/editor/components/sub-block/components/short-input/short-input.tsx
Show resolved
Hide resolved
...pp/workspace/[workspaceId]/w/components/preview/components/preview-editor/preview-editor.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Summary
Type of Change
Testing
Tested manually
Checklist