-
Notifications
You must be signed in to change notification settings - Fork 3.3k
v0.5.85: deployment improvements #3171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* improvement(deploy-modal): error and warning ui * fix(ui): terminal top border render
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile Summaryimproved deployment UI consistency and fixed trigger ID resolution logic for tools in trigger mode. The error/warning display was refactored to use Badge components instead of custom styled divs, and the state management was unified by renaming
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant DeployModal
participant DeployMutation
participant DeployAPI
participant TriggerResolver
User->>DeployModal: Click Deploy/Redeploy
DeployModal->>DeployModal: Clear errors/warnings
DeployModal->>DeployMutation: mutateAsync(workflowId)
DeployMutation->>DeployAPI: POST /api/deploy
DeployAPI->>TriggerResolver: resolveTriggerId(block)
alt Block is trigger category
TriggerResolver->>TriggerResolver: Check blockConfig.category === 'triggers'
TriggerResolver-->>DeployAPI: Return block.type
else Block has triggerMode
TriggerResolver->>TriggerResolver: Check block.triggerMode
TriggerResolver->>TriggerResolver: Check selectedTriggerId
TriggerResolver->>TriggerResolver: Check storedTriggerId
TriggerResolver->>TriggerResolver: Check configured trigger
TriggerResolver-->>DeployAPI: Return resolved triggerId
else No trigger
TriggerResolver-->>DeployAPI: Return undefined
end
DeployAPI-->>DeployMutation: Return result with warnings
DeployMutation-->>DeployModal: Return deployment result
alt Has warnings
DeployModal->>DeployModal: setDeployWarnings(warnings)
DeployModal->>User: Display amber Badge with warnings
else Error occurred
DeployModal->>DeployModal: setDeployError(errorMessage)
DeployModal->>User: Display red Badge with error
else Success
DeployModal->>User: Show success state
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Summary