Skip to content

Conversation

@icecrasher321
Copy link
Collaborator

Summary

emir-karabeg and others added 2 commits February 8, 2026 11:08
* improvement(deploy-modal): error and warning ui

* fix(ui): terminal top border render
@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 9, 2026 6:31pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 9, 2026

Greptile Overview

Greptile Summary

improved deployment UI consistency and fixed trigger ID resolution logic for tools in trigger mode. The error/warning display was refactored to use Badge components instead of custom styled divs, and the state management was unified by renaming apiDeployError/apiDeployWarnings to deployError/deployWarnings. The trigger resolution logic was fixed to prioritize checking if a block is a trigger category block or has triggerMode enabled before attempting to resolve selectedTriggerId or storedTriggerId, preventing incorrect fallback behavior for tools with trigger mode.

  • refactored error/warning UI in deploy modal to use Badge component with red/amber variants
  • removed duplicate error display from API tab since errors are now shown at modal level
  • unified state variable naming from apiDeployError/apiDeployWarnings to deployError/deployWarnings
  • fixed resolveTriggerId logic to check blockConfig.category === 'triggers' and block.triggerMode early in the function
  • adjusted terminal styling to apply border directly to container instead of nested div

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are well-scoped improvements with no logical errors. The trigger ID resolution fix addresses a real bug by checking trigger blocks and triggerMode first, preventing incorrect fallback behavior. The UI refactoring consolidates error/warning display using the established Badge component pattern, improving consistency. The terminal styling change is a minor CSS adjustment. No security concerns or breaking changes detected.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx renamed error/warning state variables, refactored error/warning UI to use Badge component
apps/sim/lib/webhooks/deploy.ts fixed trigger ID resolution order to check trigger blocks and triggerMode first

Sequence Diagram

sequenceDiagram
    participant User
    participant DeployModal
    participant DeployMutation
    participant DeployAPI
    participant TriggerResolver
    
    User->>DeployModal: Click Deploy/Redeploy
    DeployModal->>DeployModal: Clear errors/warnings
    DeployModal->>DeployMutation: mutateAsync(workflowId)
    DeployMutation->>DeployAPI: POST /api/deploy
    DeployAPI->>TriggerResolver: resolveTriggerId(block)
    
    alt Block is trigger category
        TriggerResolver->>TriggerResolver: Check blockConfig.category === 'triggers'
        TriggerResolver-->>DeployAPI: Return block.type
    else Block has triggerMode
        TriggerResolver->>TriggerResolver: Check block.triggerMode
        TriggerResolver->>TriggerResolver: Check selectedTriggerId
        TriggerResolver->>TriggerResolver: Check storedTriggerId
        TriggerResolver->>TriggerResolver: Check configured trigger
        TriggerResolver-->>DeployAPI: Return resolved triggerId
    else No trigger
        TriggerResolver-->>DeployAPI: Return undefined
    end
    
    DeployAPI-->>DeployMutation: Return result with warnings
    DeployMutation-->>DeployModal: Return deployment result
    
    alt Has warnings
        DeployModal->>DeployModal: setDeployWarnings(warnings)
        DeployModal->>User: Display amber Badge with warnings
    else Error occurred
        DeployModal->>DeployModal: setDeployError(errorMessage)
        DeployModal->>User: Display red Badge with error
    else Success
        DeployModal->>User: Show success state
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@icecrasher321 icecrasher321 merged commit 654cb2b into main Feb 9, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants