Skip to content

improvement(ui): deploy modal, terminal#3167

Merged
emir-karabeg merged 2 commits intostagingfrom
improvement/deploy-error
Feb 8, 2026
Merged

improvement(ui): deploy modal, terminal#3167
emir-karabeg merged 2 commits intostagingfrom
improvement/deploy-error

Conversation

@emir-karabeg
Copy link
Collaborator

@emir-karabeg emir-karabeg commented Feb 8, 2026

Summary

  • improvement: deploy modal error component
  • fix: terminal border top rendering

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

Solo.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 8, 2026 7:05pm

Request Review

@emir-karabeg
Copy link
Collaborator Author

@greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 8, 2026

Greptile Overview

Greptile Summary

This PR makes two UI tweaks:

  • Deploy modal: consolidates deploy error/warning rendering into a single badge strip at the top of the modal, and removes the API-tab-local error banner prop (apiDeployError) from ApiDeploy.
  • Terminal: moves the top border styling from the inner wrapper to the outer terminal container to fix a top-border rendering artifact.

No merge-blocking bugs were found in the changeset; the modifications are localized and consistent with existing component usage patterns.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are small, localized UI adjustments (state rename + error/warning badge rendering; CSS class move for border) with no behavioral impact on data fetching/mutations beyond presentation.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/api/api.tsx Removes API-tab-local error prop/rendering; rest of API example rendering unchanged.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx Renames deploy error/warning state and consolidates UI into Badge-based alert strip.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx Moves terminal top border styling from inner wrapper to outer container to fix render artifact.

Sequence Diagram

sequenceDiagram
  participant U as User
  participant DM as DeployModal
  participant AP as ApiDeploy (tab)
  participant DQ as deployMutation
  participant AQ as activateVersionMutation
  participant UI as Badge strip

  U->>DM: Open modal
  DM->>DM: reset deployError/deployWarnings
  U->>DM: Click Deploy/Redeploy
  DM->>DQ: mutateAsync(workflowId)
  alt success w/ warnings
    DQ-->>DM: {warnings[]}
    DM->>DM: setDeployWarnings(warnings)
  else error
    DQ-->>DM: throw error
    DM->>DM: setDeployError(message)
  end
  DM->>UI: render error/warning badges
  U->>DM: Switch to API tab
  DM->>AP: render API examples
  U->>DM: Promote version
  DM->>AQ: mutateAsync(version)
  AQ-->>DM: {warnings[]}/error
  DM->>UI: render warning badges (errors logged)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@emir-karabeg emir-karabeg merged commit 4193007 into staging Feb 8, 2026
11 checks passed
@emir-karabeg emir-karabeg deleted the improvement/deploy-error branch February 8, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant