fix(netsuite): validate SuiteQL pages against their documented shape

The shared collection-page validator required links, items, count,
hasMore, offset, and totalResults on every 200, and a missing field turns
a successful call into a reported failure.

Oracle documents all six for record collections and SuiteAnalytics
dataset pages, but its SuiteQL reference lists only links, count, offset,
totalResults, and items. A documented SuiteQL response that omits hasMore
would therefore have been rejected.

Split out a suiteql-page validator that requires the five documented
SuiteQL fields and type-checks hasMore only when the account returns it.
Record collections and dataset pages keep requiring all six.

Author: waleedlatif1

apps/sim/tools/netsuite/execute_suiteql.ts

@@ -44,7 +44,7 @@ export const netsuiteExecuteSuiteQLTool: ToolConfig<NetSuiteSuiteQLParams, NetSu
       () => ({
         method: 'POST',
         path: '/services/rest/query/v1/suiteql',
-        success: { status: 200, body: 'object', validator: 'collection-page' },
+        success: { status: 200, body: 'object', validator: 'suiteql-page' },
         query: normalizePagination(params.limit, params.offset),
         headers: { Prefer: 'transient' },
         body: { q: requiredTrim(params.query, 'SuiteQL query') },

apps/sim/tools/netsuite/netsuite.test.ts

@@ -753,6 +753,42 @@ describe('NetSuite operation contracts', () => {
     )
   })
 
+  it('accepts a SuiteQL page without hasMore but still requires it on record collections', async () => {
+    // Oracle's SuiteQL reference lists links, count, offset, totalResults, and
+    // items — but not hasMore — while record collections document all six.
+    const suiteqlPage = { links: [], items: [], count: 0, offset: 0, totalResults: 0 }
+    const responses = [
+      new Response(JSON.stringify(suiteqlPage), {
+        status: 200,
+        headers: { 'Content-Type': 'application/json' },
+      }),
+      new Response(JSON.stringify({ ...suiteqlPage, hasMore: 'nope' }), {
+        status: 200,
+        headers: { 'Content-Type': 'application/json' },
+      }),
+      new Response(JSON.stringify(suiteqlPage), {
+        status: 200,
+        headers: { 'Content-Type': 'application/json' },
+      }),
+    ]
+    vi.stubGlobal(
+      'fetch',
+      vi.fn(async () => responses.shift() ?? new Response('{}'))
+    )
+
+    const suiteql = await invoke(netsuiteExecuteSuiteQLTool, { query: 'SELECT id FROM customer' })()
+    const badHasMore = await invoke(netsuiteExecuteSuiteQLTool, {
+      query: 'SELECT id FROM customer',
+    })()
+    const records = await invoke(netsuiteListRecordsTool, { recordType: 'customer' })()
+
+    expect(suiteql.success).toBe(true)
+    expect(badHasMore.success).toBe(false)
+    expect(badHasMore.error).toContain('hasMore')
+    expect(records.success).toBe(false)
+    expect(records.error).toContain('hasMore')
+  })
+
   it('treats the upsert and transform Location header as optional', async () => {
     vi.stubGlobal(
       'fetch',

apps/sim/tools/netsuite/utils.ts

@@ -24,6 +24,7 @@ const MAX_JSON_NESTING_DEPTH = 100
 const MAX_JSON_NODE_COUNT = 100_000
 type NetSuiteSuccessValidator =
   | 'collection-page'
+  | 'suiteql-page'
   | 'record-action'
   | 'metadata-catalog'
   | 'async-job'
@@ -675,7 +676,9 @@ function validateSuccessBody(
 
   switch (successCase.validator) {
     case 'collection-page':
-      return validateCollectionPage(data)
+      return validateCollectionPage(data, { label: 'collection page', requireHasMore: true })
+    case 'suiteql-page':
+      return validateCollectionPage(data, { label: 'SuiteQL page', requireHasMore: false })
     case 'record-action':
       return data.result === true
         ? null
@@ -748,24 +751,39 @@ function validateMetadataCatalog(data: Record<string, unknown>): string | null {
   return null
 }
 
-function validateCollectionPage(data: Record<string, unknown>): string | null {
-  const error = validateRequiredProperties(
-    data,
-    {
-      links: 'array',
-      items: 'array',
-      count: 'number',
-      hasMore: 'boolean',
-      offset: 'number',
-      totalResults: 'number',
-    },
-    'collection page'
-  )
+/**
+ * Validates a documented NetSuite collection page.
+ *
+ * Oracle documents `hasMore` on record collections and SuiteAnalytics dataset
+ * pages, but its SuiteQL reference lists only `links`, `count`, `offset`,
+ * `totalResults`, and `items`. SuiteQL therefore validates `hasMore` only when
+ * the account actually returns it, so a documented SuiteQL page is never
+ * reported as a failed request.
+ * @see https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_156414087576.html
+ * @see https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_157909186990.html
+ */
+function validateCollectionPage(
+  data: Record<string, unknown>,
+  { label, requireHasMore }: { label: string; requireHasMore: boolean }
+): string | null {
+  const properties: Record<string, 'array' | 'boolean' | 'number' | 'object' | 'string'> = {
+    links: 'array',
+    items: 'array',
+    count: 'number',
+    offset: 'number',
+    totalResults: 'number',
+  }
+  if (requireHasMore) properties.hasMore = 'boolean'
+
+  const error = validateRequiredProperties(data, properties, label)
   if (error) return error
+  if (!requireHasMore && data.hasMore !== undefined && typeof data.hasMore !== 'boolean') {
+    return `NetSuite ${label} response did not include a valid hasMore`
+  }
   for (const key of ['count', 'offset', 'totalResults'] as const) {
     const value = data[key]
     if (!Number.isInteger(value) || (value as number) < 0) {
-      return `NetSuite collection page response included an invalid ${key}`
+      return `NetSuite ${label} response included an invalid ${key}`
     }
   }
   return null