fix(netsuite): surface upsert/transform Location, relax task link check

Oracle documents the Location response header for create and update, and
both tools already require it. Upsert and transform also produce a record
but Oracle documents no response headers for either, so they dropped the
header entirely and the new record's ID was unreachable.

Add a `resource-optional` location mode that captures Location when
NetSuite sends it and never fails when it is absent, and wire it to
upsert and transform along with their tool and block outputs.

Async task discovery rejected the whole response if any task link carried
a rel other than `self`, collapsing the picker into a 502. Oracle
documents a `self` link per task but never guarantees it is the only one,
so skip other relationships and fail only when no self link exists.

Also use the shared `truncate` helper in the error sanitizer per the
repo convention instead of an inline slice.

Author: waleedlatif1

apps/docs/content/docs/en/integrations/netsuite.mdx

@@ -159,6 +159,7 @@ Create or update a NetSuite record by external ID with PUT.
 | --------- | ---- | ----------- |
 | `status` | number | HTTP status returned by NetSuite |
 | `data` | json | Empty for the documented HTTP 204 No Content response |
+| `location` | string | URL of the created or updated record, when NetSuite returns a Location header |
 
 ### NetSuite Delete Record
 
@@ -327,6 +328,7 @@ Transform a supported source record into another NetSuite record type.
 | --------- | ---- | ----------- |
 | `status` | number | HTTP status returned by NetSuite |
 | `data` | json | Empty for the documented HTTP 204 No Content response |
+| `location` | string | URL of the transformed record, when NetSuite returns a Location header |
 
 ### NetSuite Batch Get Records
 

apps/sim/app/api/tools/netsuite/objects/route.test.ts

@@ -234,6 +234,49 @@ describe('POST /api/tools/netsuite/objects', () => {
     })
   })
 
+  it('skips non-self task link relationships instead of failing discovery', async () => {
+    const href = `${ORIGIN}/services/rest/async/v1/job/job-1/task/task-1`
+    mockGetAsyncStatus.mockResolvedValueOnce(
+      success({
+        items: [
+          {
+            links: [
+              { rel: 'canonical', href: `${ORIGIN}/services/rest/async/v1/job/job-1` },
+              { rel: 'self', href },
+            ],
+          },
+        ],
+      })
+    )
+
+    const response = await POST(
+      request({ ...RECORD_TYPES_BODY, kind: 'async_tasks', jobId: 'job-1' }),
+      {}
+    )
+
+    expect(response.status).toBe(200)
+    expect(await json(response)).toEqual({
+      objects: [{ id: 'task-1', label: 'task-1', detail: null }],
+    })
+  })
+
+  it('fails discovery when a task entry has no self link', async () => {
+    mockGetAsyncStatus.mockResolvedValueOnce(
+      success({
+        items: [
+          { links: [{ rel: 'canonical', href: `${ORIGIN}/services/rest/async/v1/job/job-1` }] },
+        ],
+      })
+    )
+
+    const response = await POST(
+      request({ ...RECORD_TYPES_BODY, kind: 'async_tasks', jobId: 'job-1' }),
+      {}
+    )
+
+    expect(response.status).toBe(502)
+  })
+
   it('normalizes, deduplicates, and sorts up to 1,000 unique record types', async () => {
     const items = Array.from({ length: 1_000 }, (_, index) => ({
       name: `record_${String(999 - index).padStart(4, '0')}`,

apps/sim/app/api/tools/netsuite/objects/route.ts

@@ -152,10 +152,14 @@ function normalizeAsyncTasks(
     if (!Array.isArray(item.links) || item.links.length === 0 || !item.links.every(isPlainRecord)) {
       throw new Error('NetSuite returned malformed asynchronous task links')
     }
-    for (const link of item.links) {
-      if (link.rel !== 'self') {
-        throw new Error('NetSuite returned an unexpected asynchronous task link relationship')
-      }
+    // Oracle documents a `self` link per task but never guarantees it is the
+    // only relationship on the entry, so additional rels are skipped rather
+    // than failing the whole picker.
+    const selfLinks = item.links.filter((link) => link.rel === 'self')
+    if (selfLinks.length === 0) {
+      throw new Error('NetSuite returned an asynchronous task without a self link')
+    }
+    for (const link of selfLinks) {
       const id = taskIdFromHref(link.href, origin, jobId)
       if (!objects.has(id)) {
         if (objects.size >= MAX_ASYNC_TASKS) {

apps/sim/blocks/blocks/netsuite.ts

@@ -85,6 +85,8 @@ const BATCH_OPERATIONS = [
 const LOCATION_OPERATIONS = [
   'netsuite_create_record',
   'netsuite_update_record',
+  'netsuite_upsert_record',
+  'netsuite_transform_record',
   ...BATCH_OPERATIONS,
 ]
 

apps/sim/tools/generated/tool-outputs.ts

@@ -286,6 +286,7 @@ const SOURCE_MATRIX: SourceMatrixEntry[] = [
     path: '/services/rest/record/v1/customer/eid:EXT-7',
     body: { companyName: 'Acme' },
     successStatus: 204,
+    locationPath: '/services/rest/record/v1/customer/647',
     execute: invoke(netsuiteUpsertRecordTool, {
       recordType: 'customer',
       externalId: 'EXT-7',
@@ -391,6 +392,7 @@ const SOURCE_MATRIX: SourceMatrixEntry[] = [
     path: '/services/rest/record/v1/salesOrder/3/!transform/invoice',
     body: { memo: 'Automated' },
     successStatus: 204,
+    locationPath: '/services/rest/record/v1/invoice/912',
     execute: invoke(netsuiteTransformRecordTool, {
       recordType: 'salesOrder',
       recordId: '3',
@@ -751,6 +753,33 @@ describe('NetSuite operation contracts', () => {
     )
   })
 
+  it('treats the upsert and transform Location header as optional', async () => {
+    vi.stubGlobal(
+      'fetch',
+      vi.fn(async () => new Response(null, { status: 204 }))
+    )
+
+    const upserted = await invoke(netsuiteUpsertRecordTool, {
+      recordType: 'customer',
+      externalId: 'EXT-7',
+      body: { companyName: 'Acme' },
+    })()
+    const transformed = await invoke(netsuiteTransformRecordTool, {
+      recordType: 'salesOrder',
+      recordId: '3',
+      targetRecordType: 'invoice',
+      body: { memo: 'Automated' },
+    })()
+
+    // Oracle documents the Location header for create and update but not for
+    // upsert or transform, so a response without it must still succeed.
+    for (const result of [upserted, transformed]) {
+      expect(result.success).toBe(true)
+      expect(result.output?.status).toBe(204)
+      expect(result.output?.location).toBeUndefined()
+    }
+  })
+
   it('validates required metadata items and optional catalog and record-type links', async () => {
     const cases = [
       { body: { items: [{ name: 'customer' }] }, success: true },
@@ -897,7 +926,13 @@ describe('NetSuite operation contracts', () => {
     ]
     expect(NetSuiteBlock.outputs.location.condition).toEqual({
       field: 'operation',
-      value: ['netsuite_create_record', 'netsuite_update_record', ...batchIds],
+      value: [
+        'netsuite_create_record',
+        'netsuite_update_record',
+        'netsuite_upsert_record',
+        'netsuite_transform_record',
+        ...batchIds,
+      ],
     })
     expect(NetSuiteBlock.outputs.jobId.condition).toEqual({
       field: 'operation',
@@ -1046,6 +1081,8 @@ describe('NetSuite operation contracts', () => {
       if (
         tool.id === 'netsuite_create_record' ||
         tool.id === 'netsuite_update_record' ||
+        tool.id === 'netsuite_upsert_record' ||
+        tool.id === 'netsuite_transform_record' ||
         batchToolIds.has(tool.id)
       ) {
         expected.push('location')

apps/sim/tools/netsuite/netsuite.test.ts

@@ -54,6 +54,7 @@ export const netsuiteTransformRecordTool: ToolConfig<
           { value: params.targetRecordType, label: 'Target record type' }
         ),
         success: { status: 204, body: 'none' },
+        responseLocation: 'resource-optional',
         body: params.body ?? {},
       }),
       signal
@@ -65,5 +66,10 @@ export const netsuiteTransformRecordTool: ToolConfig<
       description: 'Empty for the documented HTTP 204 No Content response',
       nullable: true,
     },
+    location: {
+      type: 'string',
+      description: 'URL of the transformed record, when NetSuite returns a Location header',
+      optional: true,
+    },
   },
 }

apps/sim/tools/netsuite/transform_record.ts

@@ -44,6 +44,7 @@ export const netsuiteUpsertRecordTool: ToolConfig<NetSuiteUpsertRecordParams, Ne
           { value: `eid:${requiredTrim(params.externalId, 'External ID')}`, label: 'External ID' }
         ),
         success: { status: 204, body: 'none' },
+        responseLocation: 'resource-optional',
         body: params.body,
       }),
       signal
@@ -55,5 +56,10 @@ export const netsuiteUpsertRecordTool: ToolConfig<NetSuiteUpsertRecordParams, Ne
       description: 'Empty for the documented HTTP 204 No Content response',
       nullable: true,
     },
+    location: {
+      type: 'string',
+      description: 'URL of the created or updated record, when NetSuite returns a Location header',
+      optional: true,
+    },
   },
 }

apps/sim/tools/netsuite/upsert_record.ts

@@ -1,4 +1,5 @@
 import { getErrorMessage } from '@sim/utils/errors'
+import { truncate } from '@sim/utils/string'
 import {
   DEFAULT_MAX_ERROR_BODY_BYTES,
   readResponseTextWithLimit,
@@ -44,7 +45,15 @@ interface NetSuiteRequest {
   query?: Record<string, string | number | boolean | undefined>
   headers?: Record<string, string>
   body?: unknown
-  responseLocation?: 'resource' | 'async-job'
+  /**
+   * How a `Location` response header is treated. Oracle documents the header
+   * for {@link https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_1545141395.html create}
+   * and {@link https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_1545142173.html update},
+   * so `resource` requires it. Upsert and transform also produce a record but
+   * Oracle documents no response headers for them, so `resource-optional`
+   * surfaces the header when NetSuite sends it without failing when it does not.
+   */
+  responseLocation?: 'resource' | 'resource-optional' | 'async-job'
 }
 
 /**
@@ -813,7 +822,7 @@ function validateResponseLocation(
     ) {
       return {}
     }
-    if (mode === 'resource') {
+    if (mode === 'resource' || mode === 'resource-optional') {
       return parsed.pathname.startsWith('/services/rest/record/v1/') ? { location } : {}
     }
     if (parsed.search) return {}
@@ -891,8 +900,7 @@ function sanitizeErrorText(value: string, auth?: NetSuiteAuthParams): string {
     const secret = credential.trim()
     if (secret.length >= 3) sanitized = sanitized.split(secret).join('[REDACTED]')
   }
-  const trimmed = sanitized.replace(/\s+/g, ' ').trim()
-  return trimmed.slice(0, 900) || 'Unknown error'
+  return truncate(sanitized.replace(/\s+/g, ' ').trim(), 900) || 'Unknown error'
 }
 
 function isJsonObject(value: unknown): value is Record<string, unknown> {