Fix get_backup_by_id to filter by cluster_id in cross-cluster scenarios - #1235
Open
RaunakJalan wants to merge 3 commits into
Open
Fix get_backup_by_id to filter by cluster_id in cross-cluster scenarios#1235RaunakJalan wants to merge 3 commits into
RaunakJalan wants to merge 3 commits into
Conversation
After backup import, both clusters share the same UUID in the KV store. get_backup_by_id() scanned all clusters, hitting 'Multiple values present' on restore. Add optional cluster_id parameter to scope the lookup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RaunakJalan
force-pushed
the
fix/backup-get-by-id-cluster-filter
branch
from
August 11, 2026 23:54
3876e9b to
a3d9be4
Compare
When restoring a backup on a different cluster, restore_backup() fell back to backup.node_id which belongs to the source cluster, causing the restored lvol to be created on the wrong cluster's nodes. Now detect when the backup's node doesn't belong to the target cluster and automatically select an online node from the target cluster. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This reverts commit 6e74eec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After backup import, both clusters share the same UUID in the KV store. get_backup_by_id() scanned all clusters, hitting 'Multiple values present' on restore. Add optional cluster_id parameter to scope the lookup.