Harden database accessors#1150
Open
mxsrc wants to merge 2 commits into
Open
Conversation
Lacking these hid an error where `None` could be passed into `get_cluster_by_id`, silently yielding a random cluster.
The internals of the database make it easy to inadvertently return multiple values instead of single ones. This introduces a helper to catch this situation early and expose it via an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internals in the database make it easy to get multiple or no values when they are expected. The same functions are used to return multiple or a single values, differentiated by passing an optional value. If a value is passed that is semantically expected to be present, but None for whatever reason, this causes fault that depend on the individual helper.
get_cluster_by_idreturns a random cluster in that case, for example.This PR attempts to alleviate this without touching the database internals: