fix: pass snapshot UUID instead of object to snapshot_controller.dele…#1025
Open
geoffrey1330 wants to merge 34 commits into
Open
fix: pass snapshot UUID instead of object to snapshot_controller.dele…#1025geoffrey1330 wants to merge 34 commits into
geoffrey1330 wants to merge 34 commits into
Conversation
…te in delete_last_snapshot_if_needed
geoffrey1330
force-pushed
the
modify_snapshot_replication
branch
from
fb70092 to
c9e40ac
Compare
Passing the log-level to the debug flag is invalid, this likely simply enables debug mode.Running this in debug mode is a security risk. This can be overridden using the FLASK_DEBUG environment variable.
…disabled to correctly skip SSL context when TLS is disabled
…_on_source_cluster and fix lvol_events crash on missing node
… graceful retry instead of RuntimeError
…nt false with 200
…instead of full NQN
… suffix instead of full NQN" This reverts commit 1a43072.
…instead of full NQN
…and use source_replicated_snap_uuid for failback snapshot recovery
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…d instead of retrying indefinitely
…mal replication restart on cluster recovery
| try: | ||
| target_node = db_controller.get_storage_node_by_id(lvol.replication_node_id) | ||
| target_cluster_id = target_node.cluster_id | ||
| except KeyError: |
…urce_lvol_id without replicate_to_source filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…te in delete_last_snapshot_if_needed