agent: report PRXY broker errors as proxy-to-relay errors - #1842
Merged
epoberezkin merged 3 commits intoAug 6, 2026
Conversation
The proxy returns PROXY BROKER errors only when it fails to connect to the
destination relay, but for PRXY they were mapped to SMP <proxy> (PROXY ...),
losing the relay address, so the clients reported them as errors of the
connection to the forwarding server. Map them to PROXY {proxyServer,
relayServer, ...}, the same shape PFWD errors already use.
Narasimha-sc
force-pushed
the
nd/proxy-relay-error
branch
from
August 5, 2026 17:56
eded5f4 to
ac778a0
Compare
Narasimha-sc
changed the title
Narasimha-sc
marked this pull request as draft
August 5, 2026 21:34
epoberezkin
reviewed
Aug 5, 2026
Reverts 826a237. ProxyResponseError wraps PCEResponseError, a response that failed to parse, and both clients match protocolError when rendering this error, so the connect alert falls through to the raw error dump - and released clients cannot render it at all. temporaryAgentError and serverHostError also match ProxyProtocolError only, so the failure stops being retried and proxy fallback no longer engages.
Narasimha-sc
marked this pull request as ready for review
August 6, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With private routing enabled, a failure to reach the destination relay is reported as "Error connecting to forwarding server ", blaming a server the client connected to successfully; retrying just names the next preset server.
The proxy returns
PROXY (BROKER ...)only when it fails to reach the relay, butPRXYresponses were mapped toSMP <proxy> (PROXY ...)(Agent/Client.hs:713), discarding the relay address, so both clients read them as client-to-proxy failures.This maps that one class to
PROXY {proxyServer, relayServer, ...}— the shapePFWDerrors already use — so the existing client alerts name both servers with no app change. Rationale, guard width and blast radius inplans/2026-08-05-proxy-relay-error-attribution.md.