Reflect issuer_state in access_token#317
Merged
cicnavi merged 22 commits intosimplesamlphp:wip-vcifrom Oct 24, 2025
Merged
Conversation
IssuerStateRule is already set to be executed on AuthCodeGrant: src/Server/Grants/AuthCodeGrant.php:754
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## wip-vci #317 +/- ##
=============================================
- Coverage 42.31% 42.07% -0.24%
- Complexity 1870 1883 +13
=============================================
Files 160 160
Lines 8565 8620 +55
=============================================
+ Hits 3624 3627 +3
- Misses 4941 4993 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Conformance tests are passing, which is good! Tomorrow I'll try to implement issuer state check for the internal issuer, as otherwise I'll miss that check. |
Collaborator
|
@mrvanes please check if everything works for you after all the changes. |
Collaborator
Author
|
Everything still works like a charm after the refinement commits. Thank you! |
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To completely separate the issuer from authorization server the
issuer_stateshould not be checked in the authorization endpoint, but simply be accepted as an opaque identifier and afterwards be reflected in theaccess_token.The issuer then should compare the previously offered
issuer_stateagainst theissuer_statein theaccess_tokenin order to verify that the state in theaccess_tokenreflects the received claims of theuserinfoendpoint.This PR does not implement the native issuer
access_tokenissuer_stateinspection!