This appears to be the only place that is causing the entityid issue#66
Merged
tvdijen merged 2 commits intobugfix/http-clientfrom Mar 18, 2026
Merged
This appears to be the only place that is causing the entityid issue#66tvdijen merged 2 commits intobugfix/http-clientfrom
tvdijen merged 2 commits intobugfix/http-clientfrom
Conversation
Bumps the all-actions group with 3 updates: [simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml](https://github.com/simplesamlphp/simplesamlphp-test-framework), [simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml](https://github.com/simplesamlphp/simplesamlphp-test-framework) and [geekyeggo/delete-artifact](https://github.com/geekyeggo/delete-artifact). Updates `simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml` from 1.11.1 to 1.11.3 - [Commits](simplesamlphp/simplesamlphp-test-framework@v1.11.1...v1.11.3) Updates `simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml` from 1.11.1 to 1.11.3 - [Commits](simplesamlphp/simplesamlphp-test-framework@v1.11.1...v1.11.3) Updates `geekyeggo/delete-artifact` from 5 to 6 - [Release notes](https://github.com/geekyeggo/delete-artifact/releases) - [Changelog](https://github.com/GeekyEggo/delete-artifact/blob/main/CHANGELOG.md) - [Commits](GeekyEggo/delete-artifact@v5...v6) --- updated-dependencies: - dependency-name: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml dependency-version: 1.11.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-actions - dependency-name: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml dependency-version: 1.11.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-actions - dependency-name: geekyeggo/delete-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was mentioned here #64
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## bugfix/http-client #66 +/- ##
=====================================================
Coverage 66.58% 66.58%
Complexity 154 154
=====================================================
Files 4 4
Lines 407 407
=====================================================
Hits 271 271
Misses 136 136 🚀 New features to boost your workflow:
|
Member
|
I think quality control fails because of this: We can safely ignore it. Let's merge this PR into #63 and let everyone test. #64 is wrong and should be closed. |
tvdijen
added a commit
that referenced
this pull request
Mar 18, 2026
* Fix to work with Symfony's http-client * Fix * Fix handling response codes * Repair test * Fix path to autoloader * Suppress errors from the http-clients * Properly deal with transport issues * Add warning * add underlying error to the info message * If we are using TransportException then maybe include it here too * This appears to be the only place that is causing the entityid issue (#66) * Bump the all-actions group with 3 updates (#65) Bumps the all-actions group with 3 updates: [simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml](https://github.com/simplesamlphp/simplesamlphp-test-framework), [simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml](https://github.com/simplesamlphp/simplesamlphp-test-framework) and [geekyeggo/delete-artifact](https://github.com/geekyeggo/delete-artifact). Updates `simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml` from 1.11.1 to 1.11.3 - [Commits](simplesamlphp/simplesamlphp-test-framework@v1.11.1...v1.11.3) Updates `simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml` from 1.11.1 to 1.11.3 - [Commits](simplesamlphp/simplesamlphp-test-framework@v1.11.1...v1.11.3) Updates `geekyeggo/delete-artifact` from 5 to 6 - [Release notes](https://github.com/geekyeggo/delete-artifact/releases) - [Changelog](https://github.com/GeekyEggo/delete-artifact/blob/main/CHANGELOG.md) - [Commits](GeekyEggo/delete-artifact@v5...v6) --- updated-dependencies: - dependency-name: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml dependency-version: 1.11.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-actions - dependency-name: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml dependency-version: 1.11.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-actions - dependency-name: geekyeggo/delete-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * This appears to be the only place that is causing the entityid issue This was mentioned here #64 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ben Martin <monkeyiq@users.sourceforge.net> Co-authored-by: monkeyiq <monkeyiq@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am still not sure why this is happening. But it is only being made in the
attributeauthority-remoteby this one block of code for some test federation files I have.This was mentioned here #64