Conversation
Add Alienware block to regex list
|
This is probably fine, but for non code related fixes, it is required to submit them upstream to https://github.com/matomo-org/device-detector.git. They will require a test to go with your changes. Once that is approved, this library will pull those changes naturally. |
|
An alternative, if you have real world examples of the user agent in the wild, let me know here, and I'll add it to my next pr that I send up. |
|
@mindreader I was able to find this user-agent. Feel free to open a PR when you have time.
|
|
Perfect. Thank you!
…On Thu, Jun 20, 2024, 10:25 AM Liviu-Mihail Concioiu < ***@***.***> wrote:
@mindreader <https://github.com/mindreader> I was able to find this
user-agent. Feel free to open a PR when you have time.
Mozilla/5.0 (Windows NT 10.0.18362.356; osmeta 10.3.45364)
AppleWebKit/602.1.1 (KHTML, like Gecko) Version/9.0 Safari/602.1.1
osmeta/10.3.45364 Build/45364
FBAN/FBW;FBAV/186.0.0.88.783;FBBV/171658047;FBDV/AlienwareAuroraR70858;FBMD/Alienware
Aurora R7
0858;FBSN/Windows;FBSV/10.0.18362.657;FBSS/2;FBCR/;FBID/desktop;FBLC/en_US;FBOP/45;FBRV/0
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFGHH2DYUKVS6BX65AQXULZILQ6ZAVCNFSM6AAAAABJIGVMICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQHA2DOMZRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Submitted upstream. matomo-org/device-detector#7717 |
3 participants
Add Alienware block to regex list