Fix nested chiren links in a tags - #91
Merged
Merged
Conversation
claude
Bot
added
the
change: needs review
Claude review checkpointReviewed commit |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Collaborator
|
Reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #90
Fixes auto-events not firing when a link (
<a>) wraps nested elements such as an inline SVG. The delegated click handler previously readevent.target, which resolves to the innermost clicked element (e.g. the<svg>/<path>) rather than the anchor, sosaAutomatedLinkreceived an element without link properties (href,pathname,hostname) and no event was collected. The handler now passesthis, the anchor the listener is bound to, matching the inlineonclickpath that already usesthis.Changes:
Security implications
Has security impact - described as: changes analytics data-collection behavior in the customer-facing tracking script. It is a client-side correctness fix that restores link-click event collection for anchors wrapping nested elements; it does not expose new data, change permissions, or alter data handling beyond restoring the intended tracking.
Testing
Manual testing by the author. Claude review: no automated validation run (node/build commands were not permitted in this environment); change is a one-line, isolated correctness fix in
src/auto-events.js, verified by inspection.Checklist