Warden: Don't spawn new threads when canceling#182
Open
sol wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now:
AsyncCancelledto each remaining job (from the current thread, without spawning any new threads)@simonmar from what I understand, the existing code spawns a new thread for each remaining job in the cancel queue. I'm not claiming that this is necessarily a big problem or even observable in many situations, I didn't run anything, this is purely from reading the code. BUT: The existing code also requires you to read much more code if you wanna understand what exactly is happening.
So unless I'm missing some nuance here, the new code should be both: