Skip to content

Dim the gutter and folding controls during search - #485

Merged
simonbs merged 1 commit into
mainfrom
fix/search-dimming-gutter
Nov 4, 2026
Merged

simonbs merged 1 commit into
mainfrom
fix/search-dimming-gutter

Conversation

@simonbs

@simonbs simonbs commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Search dimming leaves line numbers, folding controls, and the gutter background bright because the gutter is a sibling above the text input's find overlay.

Add a gutter dimming layer using the same color and effective find-presentation state as the text overlay. Cover the gutter's visible viewport, including navigation insets and short-document gaps, and keep dimming above controls created during layout. The layer preserves folding hit targets and the fixed gutter's position during horizontal scrolling.

Validation:

  • All 20 focused gutter, folding, search presentation, and search lifecycle tests passed on iOS 26.5.
  • Regression coverage checks rendered gutter darkening, opt-in and dismissal, inset coverage, dynamic folding-control ordering, horizontal scrolling, and folding hit targets.
  • SwiftLint and git diff --check passed.

No host-app changes are required; the app will need to update its Runestone pin after merge.

@simonbs
simonbs merged commit b1bf525 into main Nov 4, 2026
9 checks passed
@simonbs
simonbs deleted the fix/search-dimming-gutter branch November 4, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant