Repository navigation
Dim the gutter and folding controls during search - #485
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search dimming leaves line numbers, folding controls, and the gutter background bright because the gutter is a sibling above the text input's find overlay.
Add a gutter dimming layer using the same color and effective find-presentation state as the text overlay. Cover the gutter's visible viewport, including navigation insets and short-document gaps, and keep dimming above controls created during layout. The layer preserves folding hit targets and the fixed gutter's position during horizontal scrolling.
Validation:
git diff --checkpassed.No host-app changes are required; the app will need to update its Runestone pin after merge.