Skip to content

Extend search dimming behind the navigation bar - #484

Merged
simonbs merged 1 commit into
mainfrom
fix/search-dimming-insets
Nov 4, 2026
Merged

simonbs merged 1 commit into
mainfrom
fix/search-dimming-insets

Conversation

@simonbs

@simonbs simonbs commented Nov 4, 2026

Copy link
Copy Markdown
Owner

When native find is active at the top of a document, the dimming layer stops at the text content origin. The adjusted top inset remains undimmed, leaving a bright strip behind the navigation bar.

Extend dimming to the union of the text bounds and visible viewport, including navigation insets, horizontal insets, short-content gaps, and scroll bounce. Translate result cutouts into the expanded layer coordinates and refresh coverage when only the viewport changes. No host-app API or layout changes are required.

Validation:

  • All 13 focused FindResultPresentationViewTests and UITextSearchingHelperTests passed on the iOS 26.5 simulator.
  • Added regression coverage for inset coverage, aligned result cutouts, viewport-only changes, and searches without matches.
  • SwiftLint passed for both changed files; git diff --check passed.
  • Appearance in the host app has not been visually verified.

@simonbs
simonbs enabled auto-merge (squash) November 4, 2026 19:04
@simonbs
simonbs disabled auto-merge November 4, 2026 19:35
@simonbs
simonbs merged commit b1d267d into main Nov 4, 2026
9 checks passed
@simonbs
simonbs deleted the fix/search-dimming-insets branch November 4, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant