Repository navigation
Extend search dimming behind the navigation bar - #484
Merged
Merged
Conversation
simonbs
enabled auto-merge (squash)
November 4, 2026 19:04
simonbs
disabled auto-merge
November 4, 2026 19:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When native find is active at the top of a document, the dimming layer stops at the text content origin. The adjusted top inset remains undimmed, leaving a bright strip behind the navigation bar.
Extend dimming to the union of the text bounds and visible viewport, including navigation insets, horizontal insets, short-content gaps, and scroll bounce. Translate result cutouts into the expanded layer coordinates and refresh coverage when only the viewport changes. No host-app API or layout changes are required.
Validation:
FindResultPresentationViewTestsandUITextSearchingHelperTestspassed on the iOS 26.5 simulator.git diff --checkpassed.