Repository navigation
test: adopt rstest for parameterized tests #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 P2 — Pin rstest to 0.27.0 to match tauri-plugin-connectivity
This PR adds
rstest0.28.0, but the only other Silvermine project that uses rstest, tauri-plugin-connectivity, uses 0.27.0.Details
tauri-plugin-connectivity declares
rstest = { version = "0.27.0", default-features = false }incrates/connectivity/Cargo.toml. The rust-coding-standards rule on new dependencies says to use what other Silvermine projects use, or to consult the team first. rstest 0.28.0 was published on 2026-10-18.I verified the change locally: I set all four manifests to
"0.27.0"and rancargo update -p rstest --precise 0.27.0. Onlyrstestandrstest_macroschange inCargo.lock.cargo test --workspace --lib --test '*'gives 413 passed and 1 ignored, which is the same result as on 0.28.0. rstest 0.27.0 has the same default features (async-timeout,crate-name), so thedefault-features = falsecomment stays correct.Change
0.28.0to0.27.0here and in the three crate manifests, then run:Also update the sentence "rstest 0.28.0 is a dev-dependency of all four crates" in the commit body.
Comment added by AI model Claude
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending PR in tauri-plugin-connectivity to pin rstest to 0.28.0: silvermine/tauri-plugin-connectivity#38