Adjust run test action for test run in parallel #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgustinSilverfin
approved these changes
Jan 12, 2026
.github/workflows/run_tests.yml
Outdated
| if [[ "$line" =~ ^[[:space:]]+([^:]+):[[:space:]]+FAILED ]]; then | ||
| local test_name=$(echo "${BASH_REMATCH[1]}" | xargs) | ||
| if [[ -n "$current_template" ]]; then | ||
| ERRORS+=("${current_template}: ${test_name}") |
Contributor
There was a problem hiding this comment.
Nitpick: maybe we can store also template type and firm id ? It may be relevant to know in which firm it was run and failed?
Suggested change
| ERRORS+=("${current_template}: ${test_name}") | |
| ERRORS+=("[${template_type}] ${current_template}: ${test_name} (in firm ${firm_id}") |
Collaborator
Author
There was a problem hiding this comment.
Adjusted!
| # Build command with space-delimited handles | ||
| OUTPUT=$(node ./node_modules/silverfin-cli/bin/cli.js run-test -h ${HANDLES} -f "${FIRM_ID}" --status 2>&1) | ||
| parse_test_output "$OUTPUT" |
Contributor
There was a problem hiding this comment.
Not sure why we build handles as "space delimited" and accounts "quoted"?
It should be safer to always pass all of them quoted.
Also, when we build the array we are using white spaces which may conflict with with white spaces in the name/handle? here
HANDLES_BY_FIRM[${FIRM_ID}]="${HANDLES_BY_FIRM[${FIRM_ID}]} ${HANDLE_OR_NAME}"
maybe use something like | and then split the array on the | ?
HANDLES_BY_FIRM[${FIRM_ID}]="${HANDLES_BY_FIRM[${FIRM_ID}]}|${HANDLE_OR_NAME}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the changes made
Fixes # (link to the corresponding issue)
Type of change
Checklist