Remove submit-draft-signup e2e test in favor of onboarding-flow test#3687
Remove submit-draft-signup e2e test in favor of onboarding-flow test#3687pmachapman merged 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3687 +/- ##
=======================================
Coverage 81.82% 81.82%
=======================================
Files 619 619
Lines 38619 38619
Branches 6317 6317
=======================================
Hits 31601 31601
Misses 6044 6044
Partials 974 974 ☔ View full report in Codecov by Sentry. |
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion.
src/SIL.XForge.Scripture/ClientApp/e2e/workflows/onboarding-flow.ts line 116 at r1 (raw file):
await user.click(page.getByRole('option', { name: 'Yes (Up-to-Date)' })); await selectProjectByFieldName(page, user, 'Select your back translation', 'SEEC2');
This is needed to fix the e2e tests. The component previously allowed selecting resources in the "back translation" field, which of course makes no sense.
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman reviewed 4 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami).
This test was supposed to be replaced with the onboarding-flow test, which tests the drafting signup form and the steps that come after it.
This change is