Skip to content

Remove submit-draft-signup e2e test in favor of onboarding-flow test#3687

Merged
pmachapman merged 2 commits intomasterfrom
e2e/remove-submit-draft-signup-test
Feb 15, 2026
Merged

Remove submit-draft-signup e2e test in favor of onboarding-flow test#3687
pmachapman merged 2 commits intomasterfrom
e2e/remove-submit-draft-signup-test

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Feb 14, 2026

This test was supposed to be replaced with the onboarding-flow test, which tests the drafting signup form and the steps that come after it.


This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.82%. Comparing base (3379608) to head (e9f5949).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3687   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files         619      619           
  Lines       38619    38619           
  Branches     6317     6317           
=======================================
  Hits        31601    31601           
  Misses       6044     6044           
  Partials      974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nateowami made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion.


src/SIL.XForge.Scripture/ClientApp/e2e/workflows/onboarding-flow.ts line 116 at r1 (raw file):

    await user.click(page.getByRole('option', { name: 'Yes (Up-to-Date)' }));

    await selectProjectByFieldName(page, user, 'Select your back translation', 'SEEC2');

This is needed to fix the e2e tests. The component previously allowed selecting resources in the "back translation" field, which of course makes no sense.

@Nateowami Nateowami added the e2e Run e2e tests for this pull request label Feb 14, 2026
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 4 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami).

@pmachapman pmachapman self-assigned this Feb 15, 2026
@pmachapman pmachapman merged commit 2640199 into master Feb 15, 2026
28 checks passed
@pmachapman pmachapman deleted the e2e/remove-submit-draft-signup-test branch February 15, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants