Improve logging when Hangfire operation canceled#874
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
=======================================
Coverage 66.96% 66.96%
=======================================
Files 384 384
Lines 20886 20889 +3
Branches 2700 2700
=======================================
+ Hits 13986 13989 +3
Misses 5936 5936
Partials 964 964 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit).
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
|
We are seeing this same error in Mike's automatic testing. I'll go ahead and deploy this change. Hopefully, we'll then be able to track down the cause before a production release. |
I had a really weird issue on ext-QA where my jobs were getting marked as Pending/Restarting:
And it did not restart. I could not recreate it locally, nor diagnose the error on QA, apart from determine that it was coming from an
OperationCanceledexception thrown inDoWork. Worse, it was only happening for some builds - a specific build from my local instance of Scripture Forge (changing translation engines did not help).Redeploying the docker pod fixed the build, but I am still unable to determine the cause (it happened again later in the day).
To help diagnose the cause of any errors like this in future, this PR improves logging when this scenario occurs, so if it happens again, we will at least have a bit more info to go on.
This change is