Skip to content

Port 'Make Paratext project extraction case-insensitive' #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmachapman wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Port 'Make Paratext project extraction case-insensitive' #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion machine/corpora/paratext_project_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ class ParatextProjectSettings:

def get_book_id(self, file_name: str) -> Optional[str]:
"""Returns None when the file name doesn't match the pattern of a book file name for the project."""
if not file_name.startswith(self.file_name_prefix) or not file_name.endswith(self.file_name_suffix):
file_name_casefolded = file_name.casefold()
if not file_name_casefolded.startswith(self.file_name_prefix.casefold()) or not file_name_casefolded.endswith(
self.file_name_suffix.casefold()
):
return None

book_part: str = file_name[len(self.file_name_prefix) : -len(self.file_name_suffix)]
Expand Down
5 changes: 5 additions & 0 deletions tests/corpora/test_paratext_project_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ def test_get_book_id_wrong_book_part_book_num_book_id() -> None:
assert settings.get_book_id("PROJ100.SFM") is None


def test_get_book_id_case_insensitive() -> None:
settings = _create_settings("MAT")
assert settings.get_book_id("PROJMRK.sfm") == "MRK"


def _create_settings(file_name_form: str) -> ParatextProjectSettings:
return ParatextProjectSettings(
"id",
Expand Down