improve mobile edit-reference wheel picker - #491
Draft
nabalone wants to merge 4 commits into
Draft
Conversation
Replace native selects with MUI Select on desktop and @ncdai/react-wheel-picker on mobile width; update tests accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
Use 1.1rem normal-weight type and a mid-height cylinder so the mobile picker aligns with the dialog text and shows more neighbors. Co-authored-by: Cursor <cursoragent@cursor.com>
Columns now size from longest label instead of fixed widths, and selected options get iOS-style hairlines with muted unselected neighbors for clearer scrolling on mobile Mark Verses. Co-authored-by: Cursor <cursoragent@cursor.com>
Add Jest coverage for the wheel branch, remount on option-set changes after chapter clamp, align ch-based column width with option font size, and expose aria-valuetext on wheel groups. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ncdai/react-wheel-picker) for Mark Verses edit-reference, keeping MUI Select on wider viewports.Test plan
🤖 Generated with Claude Code
Made with Cursor