TT-7427 fix: disable combine with next while saving - #486
Draft
nabalone wants to merge 3 commits into
Draft
Conversation
Prevent clause boundaries from changing while a Careful Speech recording upload is in progress. Guard the combine handler as a backstop and cover the disabled state with a regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
Prevent the sibling Split Clause action from mutating segment boundaries during a recording upload. Add the same callback guard and regression coverage used for combining clauses. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep every Careful Speech boundary mutation locked during a recording upload. Guard Undo Combine and add regression coverage for its disabled state. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm test -- CarefulSpeechControls --runInBand --watchAll=falsenpm run typecheck🤖 Generated with Claude Code