refactor: internalization resource dialogs and artifact category selector - #480
Draft
nabalone wants to merge 12 commits into
Draft
refactor: internalization resource dialogs and artifact category selector#480nabalone wants to merge 12 commits into
nabalone wants to merge 12 commits into
Conversation
Keep the selected resource kind synchronized across mode changes and align upload and record action spacing. Co-authored-by: Cursor <cursoragent@cursor.com>
…rce wizard ref Make SelectArtifactCategory always render the free-solo Autocomplete (type to filter or add a category), dropping the old Select + "add new" menu variant, the now-unused `autocomplete` prop, and its dead helpers. Rename `wizardAddRef` to `isAddingAudioResourceRef` in the desktop and mobile PassageDetail artifacts components for clarity and remove stale TODO comments. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Only pass onSpeaker into MediaUploadContent for Media uploads so Resource/ProjectResource keeps hasRights and the file drop target stays usable. Co-authored-by: Cursor <cursoragent@cursor.com>
Raise the dialog to 700px when space allows, and only pin the record button with space-between in full-height mobile panes. Co-authored-by: Cursor <cursoragent@cursor.com>
Wrap MediaRecord so height:100% cannot resolve against DialogContent and open a gap above the record button. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace magic action strings shared by AddResource and both artifact views. Co-authored-by: Cursor <cursoragent@cursor.com>
Lift section/passage/general resource scope into parent state so radios stay in sync across Upload/Record remounts without a local sync effect. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring pass over the Passage Detail → Internalization resource flow. No Jira ticket.
What changed
AddResourceAction— Add Resource menu actions are now typed with an enum instead of loose values.ResourceData/PassageDetailArtifacts(+ mobile) — internalization resource state cleanup.SelectArtifactCategory— simplified the artifact category selector.UploadRecordToggle— new shared upload/record toggle component.PassageRecordDlg— substantial rework (a TODO is left in place noting it should be renamed).TranscriberAdmin-en-1.2.xliffwith regeneratedmodel.tsx/reducers.tsxand strings JSON.Notes
develop(currently behind); rebase before marking ready.🤖 Generated with Claude Code