PTX-23350: Added b marker to list of follow-on paragraph styles#855
Draft
PTX-23350: Added b marker to list of follow-on paragraph styles#855
Conversation
…ep logic in sync with Paratext
andrew-polk
approved these changes
May 9, 2023
Contributor
Author
|
Note that the production code change here is now irrelevant, since the regex has moved into Paratext and IsFollowOnParagraphStyle now relies on the version of that regex from ParatextData. The added test case is perhaps still worth checking. This is blocked for now until the PTX issue is prioritized and the corresponding test failures in Paratext are evaluated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps Glyssen's logic in sync with Paratext (until that regex is actually available in ParatextData.DLL and we can just use the "official" version).
This change is