Fix LT-21712 missing letter header for U+0493 headwords#956
Open
jasonleenaylor wants to merge 1 commit into
Open
Fix LT-21712 missing letter header for U+0493 headwords#956jasonleenaylor wants to merge 1 commit into
jasonleenaylor wants to merge 1 commit into
Conversation
GetLeadChar matched the lead character against digraph and ignorable prefixes with the default String.StartsWith, which is culture-sensitive. On .NET Framework (Windows NLS) that linguistic comparison treats U+0493 (CYRILLIC SMALL LETTER GHE WITH STROKE) as equivalent to the digraph U+0433 U+030A (ghe plus combining ring above). A headword starting with U+0493 therefore matched the primary digraph and was folded into that digraph's letter group, leaving every such entry without its own header. Compare the three prefix checks in GetLeadChar with StringComparison.Ordinal so matching is by code point, not collation. ICU-backed globalization was unaffected, which is why this reproduced only on .NET Framework. Add a regression test asserting GetLeadChar returns U+0493 for a U+0493 headword under the affected ICU rules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetLeadChar matched the lead character against digraph and ignorable prefixes with the default String.StartsWith, which is culture-sensitive. On .NET Framework (Windows NLS) that linguistic comparison treats U+0493 (CYRILLIC SMALL LETTER GHE WITH STROKE) as equivalent to the digraph U+0433 U+030A (ghe plus combining ring above).
This change is