Add wix6 skills#856
Open
johnml1135 wants to merge 5 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds documentation “skills” under .github/skills/ to guide FieldWorks’ WiX 6 migration work, with focused references for build migration, UI, upgrade/patching, and diagnostics workflows.
Changes:
- Added new WiX 6 migration skills: coordinator, build migration, UI, upgrade/patching, and diagnostics.
- Added supporting reference docs (checklists, repo maps, official/external notes, log triage, and evidence commands).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/skills/fieldworks-wix6-upgrade-patching/references/upgrade-patch-checklist.md | Adds a FieldWorks-specific upgrade/patch validation checklist and evidence capture list. |
| .github/skills/fieldworks-wix6-upgrade-patching/references/official-external-upgrade-notes.md | Curates official WiX/Windows Installer patching links and key upgrade/patch insights. |
| .github/skills/fieldworks-wix6-upgrade-patching/SKILL.md | Defines the upgrade/patching skill with required validation matrix and workflows. |
| .github/skills/fieldworks-wix6-ui/references/ui-repo-map.md | Maps the repo’s WiX 6 UI-related files and highlights high-value checks. |
| .github/skills/fieldworks-wix6-ui/references/official-ui-notes.md | Summarizes official WiX/Burn UI facts and key references for UI work. |
| .github/skills/fieldworks-wix6-ui/SKILL.md | Defines the UI skill, mental model, failure modes, and evidence expectations. |
| .github/skills/fieldworks-wix6-migration-coordinator/SKILL.md | Adds a routing/guardrail skill to direct users to the right specialist area. |
| .github/skills/fieldworks-wix6-build-migration/references/repo-build-map.md | Documents installer build entry points, targets, artifact paths, and commands. |
| .github/skills/fieldworks-wix6-build-migration/references/official-wix-build-notes.md | Curates official WiX build/migration references and key migration facts. |
| .github/skills/fieldworks-wix6-build-migration/SKILL.md | Defines build migration skill scope, rules, workflows, and validation steps. |
| .github/skills/fieldworks-installer-diagnostics/references/log-triage.md | Adds a structured recipe for reading Burn/MSI logs and diagnosing failures. |
| .github/skills/fieldworks-installer-diagnostics/references/evidence-and-commands.md | Documents artifact locations and copy/paste commands for evidence collection. |
| .github/skills/fieldworks-installer-diagnostics/SKILL.md | Defines diagnostics skill: evidence-first workflow, commands, and report format. |
| - `DisplayInternalUI` as a core `MsiPackage` attribute is not the FieldWorks WiX 6 approach. | ||
| - When internal MSI UI is shown, it appears on top of the bootstrapper UI; it is not embedded in WixStdBA. | ||
| - WixStdBA does not support EmbeddedUI. | ||
| - `MsiPackage/@Visible` controls whether the MSI appears in Programs and Features. The default is no, and FieldWorks currently authors `Visible="no"`. |
There was a problem hiding this comment.
The statement about the default value for MsiPackage/@Visible appears incorrect for WiX Burn package authoring (it is commonly yes by default, which is why projects explicitly set Visible=\"no\" to hide chained MSIs in ARP). To avoid misleading readers, please either (a) correct the documented default, or (b) remove the claim about the default and only state the FieldWorks policy: that it is authored as Visible=\"no\".
Suggested change
| - `MsiPackage/@Visible` controls whether the MSI appears in Programs and Features. The default is no, and FieldWorks currently authors `Visible="no"`. | |
| - `MsiPackage/@Visible` controls whether the MSI appears in Programs and Features. FieldWorks currently authors `Visible="no"`. |
NUnit Tests 1 files ±0 1 suites ±0 6m 17s ⏱️ -11s Results for commit 3553a21. ± Comparison against base commit 5334190. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help with the migration
This change is