Skip to content

LT-21669: Use WS numbers for headword numbers#855

Open
aror92 wants to merge 7 commits intomainfrom
LT-21669
Open

LT-21669: Use WS numbers for headword numbers#855
aror92 wants to merge 7 commits intomainfrom
LT-21669

Conversation

@aror92
Copy link
Copy Markdown
Contributor

@aror92 aror92 commented Apr 28, 2026

  • Remove option to add custom numbers from dictionary configuration > headword numbers. Instead, get the numbering system associated with the WS selected for headword numbers and display these numbers in the headword numbers configuration.
  • Ensure the WS numbering system is used for homograph/sense numbers in ConfiguredLCMGenerator.
  • In the Configure Headword Numbers dlg, use Winforms labels for number display instead of Fwtextboxes, which don't display all glyphs correctly.
  • Update WS custom number handling to include the case when a drop-down preset is selected by the user, instead of typed in custom numbers.
  • Handle UTF-16 surrogate pairs via GetUnicodeCharacters helper function in new HeadWordNumbersHelper class.
  • Update expected behavior in tests related to headword numbers.
  • Remove tests related to setting custom headword numbers, since this is no longer allowed.

This change is Reviewable

aror92 added 6 commits April 28, 2026 13:17
Change-Id: Idb7f188606c6a4354cefcbf36fc5a9ee4d35e0b4
Change-Id: I4d07442c56d056d45372e01306cd6afe900b98de
Change-Id: I12eb1013eb7a58f6f21d291d3f21bcd03acf8cb1
Change-Id: I1c1f70733d15cd4b2a439be7ec60aa22e6c650f7
Also, change Configure Headword Numbers dlg to use
Winforms labels for WS number display instead of
Fwtextboxes, which don't display all glyphs correctly

Change-Id: I72e3209a37fba682a67666ba3d02141c9a5a5edb
Also, handle KeyNotFound exceptions in getting
CoreWritingSystemDefinition for sense numbers
in ConfiguredLcmGenerator and HeadWordNumbersController.

Change-Id: I6067175b41657f9cf514b7a2a264b6cb11173376
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 12s ⏱️ -16s
4 102 tests  - 1  4 031 ✅  - 1  71 💤 ±0  0 ❌ ±0 
4 111 runs   - 1  4 040 ✅  - 1  71 💤 ±0  0 ❌ ±0 

Results for commit f1f2c3e. ± Comparison against base commit 5334190.

This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both.
SIL.FieldWorks.XWorks.HeadwordNumbersControllerTests ‑ ConstructorSetsCustomHeadwordNumbersInView
SIL.FieldWorks.XWorks.HeadwordNumbersControllerTests ‑ Ok_Disabled_WhenNotAllTenNumbersSet
SIL.FieldWorks.XWorks.HeadwordNumbersControllerTests ‑ Ok_Enabled_WithAllTenNumbers
SIL.FieldWorks.XWorks.HeadwordNumbersControllerTests ‑ ConstructorSetsHeadwordWritingSystemNumbersInView
SIL.FieldWorks.XWorks.HeadwordNumbersControllerTests ‑ CustomDigits_Default_Ok_Enabled_WhenNotAllTenNumbersSet

♻️ This comment has been updated with latest results.

Change-Id: Iacf90f64213f4f2da1c751952256cd518ac70202
@aror92 aror92 marked this pull request as draft April 28, 2026 17:49
@aror92 aror92 marked this pull request as ready for review April 29, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant