Fix LT-22422: record msa in lex entry for variants in XAmple#683
Merged
jasonleenaylor merged 1 commit intomainfrom Feb 19, 2026
Merged
Fix LT-22422: record msa in lex entry for variants in XAmple#683jasonleenaylor merged 1 commit intomainfrom
jasonleenaylor merged 1 commit intomainfrom
Conversation
Change-Id: Ice265ae442005a955be3bd0e1a9a0c1734affc31
papeh
reviewed
Feb 19, 2026
| return Tuple.Create(int.Parse(msaHvoParts[0]), msaHvoParts.Length == 2 ? int.Parse(msaHvoParts[1]) : 0); | ||
| // the msa hvo has one part or three parts separated by a period. | ||
| // in the latter case, it is the lex entry hvo, the lex ref hvo, and the msa hvo | ||
| return Tuple.Create(int.Parse(msaHvoParts[0]), msaHvoParts.Length == 3 ? int.Parse(msaHvoParts[1]) : 0, |
Contributor
There was a problem hiding this comment.
Might a user want to process an existing two-part msaHvo string?
Collaborator
Author
There was a problem hiding this comment.
No. Users never see these. The code included here is the only thing that processes these.
papeh
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LT-22422.
When producing the lexicon for XAmple, we now include the HVO for the MSA on variants. Before we just used the HVO of the lex entry and, if needed, the HVO of the lex ref. Now we always include the HVO of the MSA of the entry. This enables us to show the correct gloss and MSA info in the parse.
This change is