Fix LT-21845: Find/Replace in Texts doesn't honor match WS initially#682
Merged
jtmaxwell3 merged 2 commits intomainfrom Feb 20, 2026
Merged
Fix LT-21845: Find/Replace in Texts doesn't honor match WS initially#682jtmaxwell3 merged 2 commits intomainfrom
jtmaxwell3 merged 2 commits intomainfrom
Conversation
mark-sil
approved these changes
Feb 18, 2026
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).
All 31 Src/*/AGENTS.md files have a UTF-8 BOM (0xEF 0xBB 0xBF). The parse_frontmatter functions in four .github/*.py scripts read with encoding="utf-8", which preserves the BOM as a U+FEFF prefix on line 0, causing the "---" delimiter check to fail. This made every impacted folder report "frontmatter missing" in CI. Fix: switch file reads to utf-8-sig (strips BOM automatically) and add explicit BOM stripping in text-based parsers as defense in depth. Also update Src/FwCoreDlgs/AGENTS.md last-reviewed-tree hash to match the current code on this branch.
Contributor
|
This PR now also addresses LT-22421 - fixing the AGENTS CI check for different line endings and BOM's. |
jasonleenaylor
approved these changes
Feb 20, 2026
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-21845.
This change is