Allow setting of redirect URI port for OIDC flows#1692
Open
yashhzd wants to merge 1 commit intosigstore:mainfrom
Open
Allow setting of redirect URI port for OIDC flows#1692yashhzd wants to merge 1 commit intosigstore:mainfrom
yashhzd wants to merge 1 commit intosigstore:mainfrom
Conversation
Adds a `redirect_port` parameter to `Issuer.identity_token()` that allows callers to specify a fixed port for the local OAuth redirect server. This is needed for enterprise OIDC providers that require pre-registered redirect URIs and don't allow wildcard localhost ports. The default remains `0` (ephemeral port), preserving backward compatibility. Fixes sigstore#1029 Signed-off-by: Yash Goel <yashgoel892@gmail.com> Signed-off-by: Yash Goel <yashgoel892@gmail.com>
yashhzd
force-pushed
the
feat/redirect-port
branch
from
620f10d to
0ede8c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1029
Adds an optional
redirect_portparameter toIssuer.identity_token()that gets threaded through to the internal OAuth redirect server. This allows callers to specify a fixed port for the local redirect server instead of always using an ephemeral port (port 0).This is useful in enterprise environments where OIDC providers require a pre-registered redirect URI with a specific port.
Changes:
Issuer.identity_token(): newredirect_port: int = 0parameter (default preserves existing behavior)_OAuthFlow.__init__(): accepts and forwardsredirect_port_OAuthRedirectServer.__init__(): acceptsportparameter instead of hardcoded0Signed-off-by: Yash Goel yashgoel892@gmail.com