Fix critical and important review findings#1
Merged
Conversation
- Fix API key transport: use OpenLineageClientOptions instead of plain dict, which crashed any authenticated deployment - Wrap all emit calls in try/except so OL failures never crash SQLMesh plan execution - Thread-safe install() with threading.Lock - Fix namespace/url env var fallthrough using is-not-None checks - Fix custom facet schemaURL to point to project repo - Remove unused Model import (ruff F401) - Add tests for API key handling and emit resilience (27 total)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenLineageClient(options={"api_key": ...})passed a plain dict whereOpenLineageClientOptionsdataclass is expected, crashing any authenticated deployment. Now usesOpenLineageClientOptions(api_key=api_key).emitter.pyandconsole.pyare protected with warning-level logging.install()now usesthreading.Lockto prevent double-installation under concurrent calls.namespace or os.environ.get(...)replaced withnamespace if namespace is not None else ...so passing explicit empty string doesn't silently fall through to env vars.openlineage.iopath.from sqlmesh.core.model import Modelin datasets.py (ruff F401).