Skip to content

Stop LookML export from silently turning measures into COUNT #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosuave merged 44 commits into from
Jul 19, 2026
+3,730 −20
Merged

Stop LookML export from silently turning measures into COUNT #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
7480529
Stop LookML export from silently turning measures into COUNT
nicosuave Jun 26, 2026
7b52d64
Handle constant-count exports and protect date-part keywords in folde…
nicosuave Jul 10, 2026
4afb508
Skip zero-column aggregates on LookML export instead of emitting brok…
nicosuave Jul 10, 2026
abcad45
Keep the ALL aggregate modifier outside folded CASE filters
nicosuave Jul 17, 2026
78b2eff
Re-check folded SQL for zero columns and reject aggregate-local ORDER BY
nicosuave Jul 17, 2026
e93b691
Do not rewrite table qualifiers matching a dimension in folded filters
nicosuave Jul 17, 2026
0739c1e
Protect unquoted date-part arguments of date functions in folded filters
nicosuave Jul 17, 2026
c898722
Preserve a filtered base measure's filter in post-SQL measures
nicosuave Jul 17, 2026
29d6b6b
Make the folded-filter date-part guard position-aware
nicosuave Jul 17, 2026
d995735
Fix date-part argument positions for SQL Server DATETRUNC and drop no…
nicosuave Jul 17, 2026
6d423f4
Disambiguate DATE_TRUNC part by content and skip template-only folded…
nicosuave Jul 17, 2026
ce800b3
Treat COUNT(ALL <constant>) as a native row count
nicosuave Jul 17, 2026
6276652
Pick the DATE_TRUNC part by coarseness when both arguments are keywords
nicosuave Jul 17, 2026
fd91b47
Recognize a QUOTED DATE_TRUNC part when picking the column argument
nicosuave Jul 17, 2026
1454303
Guard the stddev/variance export path against zero-column aggregates
nicosuave Jul 17, 2026
7bcab4d
Normalize the ALL modifier out of exported complete aggregates
nicosuave Jul 17, 2026
17445f4
Protect date parts in TIMESTAMPADD/TIMESTAMPDIFF
nicosuave Jul 17, 2026
7b5f02f
Protect SQL Server datepart-first functions in folded filters
nicosuave Jul 18, 2026
8ca16cc
Protect multiline Liquid blocks when folding filters
nicosuave Jul 18, 2026
b7ca0ba
Resolve equal-rank DATE_TRUNC arguments by truncation unit
nicosuave Jul 18, 2026
f9b3141
Keep ALL normalization out of string literals
nicosuave Jul 18, 2026
4256ef4
Add SQL Server datepart abbreviations to the date-part keyword set
nicosuave Jul 18, 2026
ced8db5
Expand untemplated complete type:number bases in post-SQL measures
nicosuave Jul 18, 2026
47cb766
Neutralize {model} before the complete-SQL export agg check
nicosuave Jul 18, 2026
eeabea0
Detect aggregates on the ALL-stripped SQL for complete-measure export
nicosuave Jul 18, 2026
a4ffbce
Fold filters into multi-aggregate complete measures on export
nicosuave Jul 18, 2026
4a604e2
Skip subquery aggregates on LookML export instead of losing them
nicosuave Jul 18, 2026
f2c8602
Reject ordered-set aggregates and keep literals in folded export filters
nicosuave Jul 18, 2026
483dded
Harden folded-filter export: quote-aware scan, multi-word casts, rena…
nicosuave Jul 18, 2026
aa6f73b
Fold WITHIN GROUP aggregates and protect SQL operators in folded filters
nicosuave Jul 18, 2026
75c7c72
Guard constant SQL and raw-column aggregates in complete-SQL export
nicosuave Jul 18, 2026
f6d7fed
Protect reserved SQL grammar keywords in folded filters
nicosuave Jul 18, 2026
8e1b0ef
Only bail complete-SQL folding on renamed aggregates for force callers
nicosuave Jul 18, 2026
670ab44
Reject multi-input aggregates and resolve quoted DATE_TRUNC value col…
nicosuave Jul 18, 2026
ceb700b
Drop post-SQL measures whose base complete SQL cannot be resolved
nicosuave Jul 18, 2026
1e8a48f
Only treat single-quoted DATE_TRUNC values as the date part
nicosuave Jul 18, 2026
fdac952
Add Snowflake TIMEADD/TIMEDIFF and TRUNC/TRUNCATE to the date-part guard
nicosuave Jul 18, 2026
910db9e
Keep nullary SQL constants unqualified in folded filters
nicosuave Jul 18, 2026
0bf4787
Recognize ISO DATE_TRUNC units and disambiguate numeric TRUNC
nicosuave Jul 19, 2026
86c8e3f
Make the folded-filter {model} replacement quote-aware
nicosuave Jul 19, 2026
1e1a4fc
Strip qualifiers for TRUNC value check and skip LIST/ARRAY_AGG export…
nicosuave Jul 19, 2026
bf24ccc
Add LAST_DAY to the folded-filter date-part guard
nicosuave Jul 19, 2026
e6be1bc
Disambiguate date_diff part position by content and strip a leading A…
nicosuave Jul 19, 2026
40bf616
Fix zero-column complete-SQL CTE and recognize TRUNC date expressions
nicosuave Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading