updated error messages #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ylembachar updated Readme in this same PR. |
ulope
approved these changes
Jul 9, 2025
Contributor
ulope
left a comment
ulope
left a comment
There was a problem hiding this comment.
Some text suggestions, otherwise LGTM.
| err := httpError.NewHttpError( | ||
| fmt.Sprintf("decryption will happen based on gnosis block time, please try again later after %d seconds", registrationData.Timestamp%5), | ||
| "", | ||
| http.StatusAccepted, |
Contributor
There was a problem hiding this comment.
This should probably be a 404 instead.
Contributor
Author
There was a problem hiding this comment.
this was in accordance with what we previously discussed about error code 202 🤔
Co-authored-by: Ulrich Petri <github@ulo.pe>
Co-authored-by: Ulrich Petri <github@ulo.pe>
Co-authored-by: Ulrich Petri <github@ulo.pe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #69
also tackles gnosis block time thing from #56